fix(auth): restore the fail-closed SAML handler so master compiles (#886) - #888
Merged
Merged
Conversation
) The merge e86df5c brought the old SAML2ACS body, provisionSAML2User and applyGroupRoleMapping back from #803, while keeping #866's trimmed imports. master stopped compiling. Adding the imports would have compiled the hand-rolled ACS back in: it reads the email out of any posted XML, with no signature check, and opens a session. This restores #866's version of the file instead, where both SAML entry points refuse every request. No other file is touched. Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
alex-dembele
added
type:security
This was referenced Oct 2, 2026
fix(auth): master does not compile — a merge put the old SAML ACS body back without its imports
#886
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #886
masterdoes not compile:saml2_handler.gousesbase64,xml,strings,log,domainandgormwithout importing them.The merge
e86df5cd(master into the #866 branch, merged via #868) kept #866's trimmed imports and doc comment, but brought back #803's oldSAML2ACSbody, along withprovisionSAML2UserandapplyGroupRoleMapping.Do not fix this by adding the imports. That body opens a session for whatever email an unsigned XML names, which is the bypass #866 closed. This PR restores
069b3db8's version of the file, the one #866 intended, where both SAML entry points refuse every request. It is one file: 183 lines removed and the one-line refusal back.Verification
On the branch:
Those packages include #866's own tests,
TestSAML2ACS_RefusesAWellFormedSuccessResponseandTestSAML2ACS_RefusesAnEmptyPost, which could not compile on master.Not done
14f26e8e. Worth a look at branch protection.