Repository navigation
fix(frontend): give LoginForm its notice prop back (#893) - #894
Merged
Merged
Conversation
Merging master into the #872 branch (990b93f) resolved LoginForm's signature to the old one while its caller and body still used notice. Since PR #880 the sign-in screen threw 'notice is not defined' on render for everyone, tsc -b failed and 27 auth unit tests were red. The added test walks the only path that hands a notice up to AuthScreen: sign-up, enrolment on an expired token, back to the sign-in form with the reason. Signed-off-by: alex-dembele <alexandredembele16@gmail.com>
2 tasks
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #893
What
LoginFormgets itsnoticeprop back. The merge of master into #872's branch (990b93f3) dropped it from the signature but left it in the caller and the body. Since PR #880,/loginhas crashed on render for everyone, withReferenceError: notice is not defined.Verified
cefe453d)/loginin ChromiumReferenceError: notice is not definednpx tsc -b --noEmitnpx vitest run src/features/authnpx vitest run(whole frontend)signup.test.tsx: expired enrolment → sign-in form shows the reasonnotice is not definedNot done
mastershould have been red since 2026-10-02.