Feature/add project request validation and exception handling#11
Merged
Feature/add project request validation and exception handling#11
Conversation
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…ints - Updated OpenAPI schema for CreateProjectRequest to include field patterns, min/max lengths, and required fields using oneOf. - Removed redundant manual validation logic for projectKey, projectName, and projectDescription from ProjectRequestValidator. - Enhanced ProjectExceptionHandler to map validation errors to specific error keys and messages based on the failing field. - Extended ProjectExceptionHandlerTest with parameterized tests for various validation scenarios. - Removed obsolete tests from ProjectRequestValidatorTest. - Adjusted ProjectMapperTest to reflect removal of projectKeyPattern.
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…ions and remove unused method
|
| validateFlavorOrConfigItem(request); | ||
| } | ||
|
|
||
| private void validateFlavorOrConfigItem(CreateProjectRequest request) { |
Contributor
There was a problem hiding this comment.
Questions, the validation should be a XOR? it needs to have flavor or configitem but not both at the same time?
If that is the case, it does not work.
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.