Merged
Conversation
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
angelmp01
reviewed
Mar 25, 2026
...c/main/java/org/opendevstack/apiservice/persistence/entity/ClientAppProjectFlavorEntity.java
Outdated
Show resolved
Hide resolved
angelmp01
reviewed
Mar 25, 2026
...stence/src/main/java/org/opendevstack/apiservice/persistence/entity/ApiDefinitionEntity.java
Outdated
Show resolved
Hide resolved
angelmp01
reviewed
Mar 25, 2026
core-contracts/src/main/java/org/opendevstack/apiservice/core/contracts/error/GatewayError.java
Outdated
Show resolved
Hide resolved
angelmp01
reviewed
Mar 25, 2026
...ontracts/src/main/java/org/opendevstack/apiservice/core/contracts/persistence/ClientDao.java
Outdated
Show resolved
Hide resolved
angelmp01
reviewed
Mar 25, 2026
persistence/src/main/java/org/opendevstack/apiservice/persistence/entity/ClientAppEntity.java
Outdated
Show resolved
Hide resolved
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
…licyEntity for consistency
…iated SQL migration
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
|
…and update tests accordingly
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
|
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
core-contractsmodule, which defines the core interfaces, data structures, and contract classes for API service modules. It also integrates this new module as a dependency into thepersistencemodule. The changes lay the foundation for a modular, contract-driven architecture by specifying interfaces for API modules, authentication, policies, error handling, and persistence.The most important changes are:
Introduction of
core-contractsmodule:core-contractswith its ownpom.xml, specifying dependencies on Spring, Jackson, Lombok, and Jakarta Servlet API.API and Policy Contracts:
ApiModule), API definitions (ApiDefinition), and policy evaluation (PolicyEvaluator,PolicyRule,PolicyContext,PolicyTypes). These provide a standardized contract for API registration, discovery, and policy enforcement.Authentication and Authorization:
Introduced enums and logic for authentication types (
AuthType) and authorization decisions (AuthorizationDecision), including a utility method for combining decisions.Persistence Contracts:
Added interfaces for data access to API definitions, clients, and policies (
ApiDefinitionDao,ClientDao,PolicyDao), including read-only projections for client informationError Handling:
Introduced a simple
GatewayErrorvalue class for standardized error representation in the core contracts.Integration with Persistence Module:
persistence/pom.xmlto add a dependency on the newcore-contractsmodule, enabling the persistence layer to implement and use these contracts.