Skip to content

Update LDAP group pattern property in ProjectServiceImpl and add info…#16

Merged
jorge-romero merged 1 commit intodevelopfrom
chore/application-yaml
Apr 7, 2026
Merged

Update LDAP group pattern property in ProjectServiceImpl and add info…#16
jorge-romero merged 1 commit intodevelopfrom
chore/application-yaml

Conversation

@jorge-romero
Copy link
Copy Markdown
Contributor

This pull request makes significant improvements to the application's configuration, focusing on environment variable management, documentation, and flexibility for deployment in different environments. The main changes involve restructuring the application.yaml file to better organize configuration sections, enhance documentation, and ensure that sensitive or environment-specific values are supplied via environment variables. Additionally, there is a small fix in the ProjectServiceImpl class to align a configuration property key.

Configuration and Environment Management Improvements:

  • Refactored application.yaml to consistently use environment variables for sensitive and environment-specific settings (e.g., database credentials, OAuth2 endpoints, external service URLs), improving security and deployment flexibility.
  • Enhanced inline documentation throughout application.yaml to clarify the purpose and usage of each configuration option, making onboarding and troubleshooting easier. [1] [2] [3] [4] [5]
  • Added or expanded configuration sections for logging, Spring Boot infrastructure, security, actuator endpoints, OpenTelemetry, and external integrations (Ansible, OpenShift, Bitbucket, Projects Info Service), with detailed comments and improved defaulting via environment variables. [1] [2] [3] [4] [5]

Code Consistency and Bug Fixes:

  • Updated the property key in ProjectServiceImpl.java from ldap.group.pattern to services.project.ldap.group.pattern to match the new configuration structure, ensuring the correct value is injected.

@jorge-romero jorge-romero requested a review from angelmp01 April 6, 2026 15:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

📊 Static Analysis Summary

🔍 Code Quality Checks

  • ✅ JaCoCo coverage report generated

📦 Download detailed reports from the workflow artifacts.

@jorge-romero jorge-romero merged commit aee0c8f into develop Apr 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants