Feature/whitelisted urls ignore tokens no matter valid invalid or expired extra filter validation#25
Merged
sergio-soria-bi merged 7 commits intomasterfrom Mar 31, 2026
Conversation
… is only needed when CSRF is enabled).
sergio-soria-bi
requested review from
hrcornejo,
jordivx and
sergio-esperalta-bi
|
hrcornejo
approved these changes
Mar 31, 2026
sergio-soria-bi
deleted the
feature/whitelisted-urls-ignore-tokens-no-matter-valid-invalid-or-expired_extra_filter_validation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AadAppRoleStatelessAuthenticationFilter tries to get a valid UserPrincipal on every request (no matter if it is whitelisted).
That's ok if token is not existing, if token is invalid, but if token is valid but expired, AadAppRoleStatelessAuthenticationFilter rejects request.
That's an issue, and sadly, AadAppRoleStatelessAuthenticationFilter does not offer an option to ignore that.
This MR will introduce a custom preFilter, ConditionalAadFilter, that will skip AadAppRoleStatelessAuthenticationFilter if request is whitelisted.