Repository navigation
Fields almost aligned with whitepaper - #205
Merged
Merged
Conversation
…ptions-and-last-bits
This was referenced Jul 16, 2026
Collaborator
Author
|
James verbally approves! |
mccalluc
enabled auto-merge (squash)
September 11, 2026 16:53
mccalluc
disabled auto-merge
September 11, 2026 17:08
mccalluc
enabled auto-merge (squash)
September 11, 2026 17:09
mccalluc
disabled auto-merge
September 11, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearing the final changes to the schema necessary to match the whitepaper, and update all the data files to validate against the schema.
TODO:
model_name_details,actors,data_source_type: Decide how the information currently in these fields should be mapped.Output of
dump.py:Discrepancies between this and the whitepaper:
url_slugat the top level. It's not part of the user-visible data, so it seems good to keep it out ofdeployment.data_product_sectorandpublication_dateso the threedata_product_*fields are together. (Doesn't matter for json schema validation, but we also check the order of the keys, and the keys are displayed in the given order in the UI, so it does have consequences.)data_curatorsincludes both "data_curator_name" and "data_curator_type"privacy_unit_details: Use "details" rather than "description" for consistency. I believe James confirmed verbally that the whitepaper should be corrected.data_source_typerather than just "data source". "Type" seems more appropriate for an enumerated field like this.model_name_details,actors,data_source_typeretained because I was unsure where to move the information they contain.sourcestoadministrative. (and Supportevidence source#172 will start to movesourcesthe more structuredevidence_sources)