Skip to content

Require source tags to be globally unique - #212

Merged
tercer merged 3 commits into
clean-data-plus-citationsfrom
clean-data-plus-citations-uniq-tags
Sep 11, 2026
Merged

tercer merged 3 commits into
clean-data-plus-citationsfrom
clean-data-plus-citations-uniq-tags

Conversation

@mccalluc

Copy link
Copy Markdown
Collaborator

Thinking about how this will be used downstream in the UI, we're probably going to want anchor links from the field to the citation information. It makes the UI code a little simpler if it can assume these strings are unique, but this is not the only way it could work!

I guess I'm bringing it up now, because once we start filling in the citations on every field, if we later decide we do need global uniqueness, it will be a little more work to correct everything after the fact.

@mccalluc
mccalluc requested a review from tercer August 13, 2026 16:36
administrative:
evidence_sources:
documentation:
convid19_documentation:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convid -> covid

year: 2021
month: 2
paper:
convid19_paper:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

month: September
url: https://arxiv.org/pdf/2009.01265
data_product:
convid19_data_product:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@tercer tercer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small spelling. should discuss about uniqueness

@mccalluc

Copy link
Copy Markdown
Collaborator Author

Once typos are fixed, James says approved.

@tercer
tercer self-requested a review September 11, 2026 16:58
@tercer
tercer merged commit 4a56404 into clean-data-plus-citations Sep 11, 2026
1 check passed
@tercer
tercer deleted the clean-data-plus-citations-uniq-tags branch September 11, 2026 16:59
mccalluc added a commit that referenced this pull request Sep 11, 2026
* in schema, move status and tier, and remove notes

* move composition and post_processing; add utility

* remove three fields

* remove unused model_name_details

* remove unused actors

* remove unused data_source_type_details

* fill in trust assumptions

* add dump.py

* add missing fields to schema

* tweak script output

* publication date to end

* evidence_sources

* move into keyed object

* check runs clean

* fix good yaml

* pytest passes

* checkpoint; all but 9 are ordered correctly

* order is clean

* Fill in citations (#211)

* copy citations from #209

* translate 3 records

* two more

* three more

* finish census

* checkpoint: some covid projects

* five more

* five more

* three more

* three more

* three more

* wikipedia!

* drop sources

* drop other options beside misc

* misc -> citation

* missing authors

* move mhusage fields to match the new schema

* and order fields

* structured citation

* Require source tags to be globally unique (#212)

* add a check for global uniqueness

* Make the tags globally unique

* finish rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants