Repository navigation
Require source tags to be globally unique - #212
Merged
tercer merged 3 commits intoSep 11, 2026
Merged
Conversation
tercer
reviewed
Sep 11, 2026
| administrative: | ||
| evidence_sources: | ||
| documentation: | ||
| convid19_documentation: |
tercer
reviewed
Sep 11, 2026
| year: 2021 | ||
| month: 2 | ||
| paper: | ||
| convid19_paper: |
tercer
reviewed
Sep 11, 2026
| month: September | ||
| url: https://arxiv.org/pdf/2009.01265 | ||
| data_product: | ||
| convid19_data_product: |
tercer
reviewed
Sep 11, 2026
tercer
left a comment
Member
There was a problem hiding this comment.
small spelling. should discuss about uniqueness
Collaborator
Author
|
Once typos are fixed, James says approved. |
tercer
self-requested a review
September 11, 2026 16:58
mccalluc
added a commit
that referenced
this pull request
Sep 11, 2026
* in schema, move status and tier, and remove notes * move composition and post_processing; add utility * remove three fields * remove unused model_name_details * remove unused actors * remove unused data_source_type_details * fill in trust assumptions * add dump.py * add missing fields to schema * tweak script output * publication date to end * evidence_sources * move into keyed object * check runs clean * fix good yaml * pytest passes * checkpoint; all but 9 are ordered correctly * order is clean * Fill in citations (#211) * copy citations from #209 * translate 3 records * two more * three more * finish census * checkpoint: some covid projects * five more * five more * three more * three more * three more * wikipedia! * drop sources * drop other options beside misc * misc -> citation * missing authors * move mhusage fields to match the new schema * and order fields * structured citation * Require source tags to be globally unique (#212) * add a check for global uniqueness * Make the tags globally unique * finish rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking about how this will be used downstream in the UI, we're probably going to want anchor links from the field to the citation information. It makes the UI code a little simpler if it can assume these strings are unique, but this is not the only way it could work!
I guess I'm bringing it up now, because once we start filling in the citations on every field, if we later decide we do need global uniqueness, it will be a little more work to correct everything after the fact.