fix(iSTA): preserve output uncertainty and conditional SDF period checks - #234
Merged
Merged
Conversation
yipeix
marked this pull request as ready for review
September 15, 2026 08:28
yipeix
enabled auto-merge
September 15, 2026 09:27
ZhishengZeng
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output timing checks ignored the uncertainty of the clock associated with
set_output_delay, making setup and hold slack optimistic. Apply setup uncertainty with a negative sign and hold uncertainty with a positive sign when calculating required time, and make the report increments add up for nonzero and negative output delays.SRAM minimum-period checks also lost their Liberty
sdf_condduring SDF export. Preserve the condition around the PERIOD pin event so distinct read/write requirements on the same clock pin do not become conflicting unconditional checks. Existing check values and unconditional formatting are preserved.The branch includes main commit
f8036144bthrough merge commitda42c5393. The production diff is limited to TimingAnalyzer.cpp, TimingReporter.cpp and SDFWriter.cpp.Validation:
ecc_binbuilds and five focused CTests pass. The new conditional PERIOD regression fails on the previous writer and passes after the fix; it covers distinct read/write limits and an unconditional check.