fix(deps): update ecc-tools row blockage handling - #264
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
This is a dependency-only gitlink bump (no ECC code/flow changes in this repo) aligned with the PR description.
Pull request overview
This PR updates the pinned ecc-tools submodule revision so ECC picks up upstream DreamPlace behavior that derives placement blockages from areas inside the core that have no placement rows, without introducing any ECC (Python/flow) code changes in this repository.
Changes:
- Bump
chipcompiler/thirdparty/ecc-toolsgitlink toa2f2fc54cf1d1745c59ce95129e4e646c90b5129. - No changes to ECC orchestration code or flow logic in this repo (dependency-only update).
File summaries
| File | Description |
|---|---|
| chipcompiler/thirdparty/ecc-tools | Updates the ecc-tools submodule pointer to the upstream commit that adjusts DreamPlace blockage derivation behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Emin017
left a comment
Emin017
left a comment
There was a problem hiding this comment.
Fatal Python error: Segmentation fault
Please fix the ci.
|
openecos-projects/ecc-tools#199 |
Pick up ecc-tools cf5b644 (fix(pyplacedb): block placement outside rows #199), which fixes row blockage handling in the pyplacedb backend. Co-Authored-By: Claude Code <noreply@anthropic.com>
8251d0b to
15d7fee
Compare
Signed-off-by: Emin <me@emin.chat>
Summary
Update the ECC-Tools gitlink to
a2f2fc54cf1d1745c59ce95129e4e646c90b5129, which derives DreamPlace placement blockages from areas inside the core that have no placement rows.This parent PR contains no ECC Python or flow changes.
Dependency
Merge the ECC-Tools PR first so the referenced gitlink remains reachable from its target repository.
Verification
origin/mainatefcd90facd7e38dfe34a918ff2f1c8d7024b94ccfix/pyplacedb-row-blockageschipcompiler/thirdparty/ecc-toolsCheck Version Consistency, commit-message/title, lint, and PyInstaller checks passCurrent CI blocker
The full parent
Testjob reachestest/integration/test_rcx_flow.py::test_ics55_gcdand exits 139 inECCToolsModule.feature_placement_map(). The GCD floorplan has 35 rows and produces zero row-derived synthetic blockages, so this failure does not exercise the new ROW geometry. The gitlink update also advances over ECC-Tools PR #197, a large EarlyRouter rewrite; local reproduction completes EarlyRouter anddestroyRT()before the same crash. The parent PR is therefore not merge-ready until that dependency integration regression is resolved or ECC updates its ECC-Tools baseline separately.