feat(cli): support external workspace paths - #288
Open
Yell-walkalone wants to merge 2 commits into
Open
Yell-walkalone wants to merge 2 commits into
Yell-walkalone wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
--pathhandling forecc runso a workspace can live outside the project directory; without it, the existing project-local workspace layout remains unchanged.ecc workspace import WORKSPACE --project PROJECT --path PATHto register an existing external workspace without opening or changing it.Scope
uv.lock, or release artifacts.Runtime And Packaging Impact
Notes:
--pathis omitted.Validation
uv run --no-sync ruff format --check chipcompiler testuv run --no-sync ruff check --output-format=github chipcompiler test54 passedECOS_PYINSTALLER_MODE=onedir uv run --no-sync --managed-python pyinstaller ecc.spec --clean --noconfirm;ecc --version,ecc run --help, andecc workspace import --helppassed./nfs/home/huangzengrong/projects/benchmark/gcd: externalecc run --path --resumereturnedno_op=True, andecc workspace import --pathregistered successfully; manifest paths matched the requested directories. No flow steps were run.nix run .#cli -- --help(not run; unrelated to this CLI change)Skipped checks and reason:
renameat2(RENAME_EXCHANGE)returnedEINVAL, and one cleanup assertion observed an NFS.nfs*file). The same affected tests pass with--basetemp=/tmpexcept the existing test that requires a complete PDK unavailable in this local fixture environment.build/anddist/directories were removed before publishing.Checklist
Co-authored-bytrailer was added.