Conversation
createEccRuntimeEnv and createRuntimeEnv now maintain ECOS_ELECTRON_RUNTIME_BIN_PATH, a PATH-style list of the bin directories the runtime layer added on top of the inherited environment, kept in resolved-PATH order. Both runtime markers are rebuilt on every construction so a nested launch (ECOS Studio started from an integrated terminal) never inherits stale entries. Integrated terminal sessions use the marker to re-apply exactly these entries after shell startup files that reset PATH.
Generate zsh/bash startup wrapper files under a userData directory and compute per-shell spawn plans so the ECOS runtime bin dirs can be re-applied after shell startup files that reset them (e.g. NixOS set-environment). The zsh wrapper preserves the user's native ZDOTDIR state and both merges preserve user rc precedence and empty PATH components.
ShellPtyService gains an optional shellStartupDir option. When set, each new session generates the zsh/bash startup wrappers and overlays the resulting plan (ZDOTDIR or --rcfile) on the spawn, so shells that reset PATH during startup still resolve the runtime bin dirs carried in ECOS_ELECTRON_RUNTIME_BIN_PATH. Generation or planning failures degrade to the previous env-only behavior with a debug log.
Pass a persistent userData shell-rc directory to ShellPtyService so the zsh/bash startup wrappers are generated and applied for every new integrated terminal session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Select the areas touched by this PR:
ecos/gui, including renderer, Electron, and shared packages.Validation
List the commands you ran. Mark checks that are not applicable as N/A.
cd ecos/gui && pnpm run typecheckcd ecos/gui && pnpm run testcd ecos/gui && pnpm run buildmake buildmake demo-gcdmake demo-retrosoccd ecos/gui && pnpm run devSkipped checks and reason:
Screenshots or Recordings
Required for visible GUI changes.
Release, Packaging, and Runtime Impact
Notes:
Checklist