Conversation
chip-viewer-native cannot be built for wasm32: main.rs parses CLI arguments and chip-view-db memory-maps its input. Add chip-viewer-wasm, which keeps the portable half — the layer styling in chip-display — behind an eframe app the host page mounts on a canvas. CI checks the target so the browser path cannot silently rot. Signed-off-by: Leo Cheng <chengkelfan@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chip-viewer-nativecannot be built forwasm32:main.rsparses CLI arguments andchip-view-dbmemory-maps its input. This addschip-viewer-wasm, which keeps the portable half — the layer styling inchip-display, whose only dependency ischipgeom-format— behind aneframeapp the host page mounts on a canvas.chip-viewer-nativeis untouched.Verification
The new CI step runs the first of these, so the browser path cannot silently rot.
index.htmlis the development shell; producing a distributable bundle needswasm-packand is left out of this PR.