Conversation
- propagate the recovered workspace revision through workspace open - project pending/failed recovery state into the background operation store - harden force-quit teardown: idempotent workspace release, coded rejections, and quiet expected IPC failures - bump ecc for the operation recovery workspace revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullfrom project discovery when the probed path is outside the granted scope.eccsubmodule for the recovery workspace revision (depends on feat(runtime): return workspace revision from interrupted operation recovery ecc#292).Scope
Select the areas touched by this PR:
ecos/gui, including renderer, Electron, and shared packages.Validation
List the commands you ran. Mark checks that are not applicable as N/A.
cd ecos/gui && pnpm run typecheckcd ecos/gui && pnpm run test(shared 102, renderer 1006, desktop-electron 905)cd ecos/gui && pnpm run build(renderer typecheck +desktop:build)cd ecos/gui && pnpm run desktop:build && pnpm run desktop:smoke(smoke withELECTRON_DISABLE_SANDBOX=1, see below)make buildmake demo-gcdmake demo-retrosoccd ecos/gui && pnpm run devpnpm run lint,pnpm run fmt:check,python3 .github/scripts/check-version.pySkipped checks and reason:
make build, demos, manual GUI smoke: not a packaging, release, version, or native-resource change; AppImage packaging intentionally not run.desktop:smokerequiresELECTRON_DISABLE_SANDBOX=1locally because this machine'schrome-sandboxhelper is not setuid root; smoke passes with sandbox disabled.Screenshots or Recordings
Required for visible GUI changes.
Release, Packaging, and Runtime Impact
Notes:
eccgitlink moves83fe68d1 -> 69c51a51(includes published #286, #289 plus feat(runtime): return workspace revision from interrupted operation recovery ecc#292, which adds the recoveryworkspaceRevisionconsumed here). Merge ecc#292 first; the gitlink can then be repointed at the squashed main commit.Checklist