fix(gui): restore params.toml workspace parameter reading - #227
Merged
Yell-walkalone merged 1 commit intoSep 17, 2026
Conversation
d851295 removed the TOML workspace config reader, so workspaces with only home/params.toml resolved an empty design name and the resource index generated artifact paths like _place.def.gz, failing chip-viewer:open with a missing response. Restore a read-only workspaceParametersFile module (locate home/params.toml with home/parameters.json fallback, flatten [design]/[pdk] section mirrors per ecc workspace_config.py) and wire it into WorkspaceResourceService index and readParameters. Re-add smol-toml and TOML workspace regression tests.
KoEkko
force-pushed
the
ekko/fix-restore-params-toml-workspace-parameters
branch
from
September 16, 2026 14:09
dddf9a2 to
c9df1d6
Compare
Yell-walkalone
approved these changes
Sep 17, 2026
KoEkko
deleted the
ekko/fix-restore-params-toml-workspace-parameters
branch
September 17, 2026 01:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceResourceServiceonly readhome/parameters.json, so workspaces with justhome/params.tomlresolved an empty design name, produced artifact paths like_place.def.gz, andchip-viewer:openfailed with amissingresponse.workspaceParametersFilemodule: locatehome/params.tomlfirst withhome/parameters.jsonfallback, flatten[design]/[pdk]TOML section mirrors per eccworkspace_config.py, and wire it into the resource index andreadParametersIPC.smol-toml(^1.8.0, same as pre-refactor) and add TOML workspace regression tests.Scope
Select the areas touched by this PR:
ecos/gui, including renderer, Electron, and shared packages.Validation
List the commands you ran. Mark checks that are not applicable as N/A.
cd ecos/gui && pnpm run typecheckcd ecos/gui && pnpm run testcd ecos/gui && pnpm run buildcd ecos/gui && pnpm run desktop:build && pnpm run desktop:smokemake buildmake demo-gcdmake demo-retrosoccd ecos/gui && pnpm run devpython3 .github/scripts/check-version.py;cd ecos/gui && pnpm install --frozen-lockfile && pnpm run lint && pnpm run fmt:checkSkipped checks and reason:
make build,make demo-gcd,make demo-retrosoc, manual GUI smoke: no release, packaging, version-metadata, native-resource, or ECC runtime change and no visible GUI change.desktop:smokeran locally on the real display (no xvfb) withELECTRON_DISABLE_SANDBOX=1andECOS_ELECTRON_DISABLE_GPU=1; the Linux AppImage packaging job is covered by CI.Screenshots or Recordings
Required for visible GUI changes.
Release, Packaging, and Runtime Impact
Notes:
smol-tomlruntime dependency to@ecos-studio/desktop-electron;pnpm-lock.yamlupdate is included.Checklist