Only try to load available.conf when auto conf is enabled #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not running emonhub on emonpi and I don't have anything at hard coded path /opt/openenergymonitor/emonhub/conf/available.conf so stock emonhub will not run for me unless I create that hard coded path and I'm a bit pedantic! It'd be nice to be able to run stock emonhub on instances which are not setup with the full emonpi payload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emonhub tries to load available.conf from the fixed path /opt/openenergymonitor/emonhub/conf/available.conf even when autoconf = 0, resulting in an error being logged and sys.exit being called. sys.exit exits the main thread but not the emonhub process leaving the interfacer threads running without any main thread to transfer packets over the message bus between them.
These commits attempt to load available.conf only when autoconf is enabled and where autoconf is enabled and available.conf cannot be loaded ensures the whole process exits.