Repository navigation
Feat/kubernetes job secret management - #18
Merged
Merged
Conversation
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
…builders Signed-off-by: amh1k <abdulmoizx97@gmail.com>
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds coordinator support for creating a benchmark Job and its temporary credential Secret in the configured workload namespace.
The coordinator creates the Secret first, then creates a Job that references it. If Job creation fails, the coordinator attempts to delete the Secret and reports any cleanup error alongside the original failure.
Changes
Testing
Added unit tests covering manifest configuration, creation order, Secret references, validation, API failures, cancellation, and cleanup error handling.
Verified with:
go -C backend test ./... go -C backend vet ./... git diff --checkFollow-up
Job monitoring, output collection, complete resource cleanup, and wiring the
Run()method are covered by the second subissue #17 . This PR does not expose benchmark execution through an API endpoint.Closes #16