Repository navigation
Feat/benchmark job lifecycle - #22
Merged
Merged
Conversation
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the benchmark Job lifecycle through
Coordinator.Run: create temporary credentials and a runner Job, wait for execution, collect output, and clean up Kubernetes resources.Closes #17
Changes
Coordinator.Run.Testing
go vet, andgit diff --check.Scope and limitations
This PR provides the internal coordinator execution flow. Benchmark creation and status API endpoints are covered by #12.
Output is returned as raw text; metric parsing and persistence are separate work. Credential sanitization remains outstanding. A coordinator crash can leave temporary resources behind; automatic recovery is not implemented.