Repository navigation
Conversation
Right now plugin-hub always fetches index.json from GitHub, so a cluster with no outbound internet access can never populate its catalog. Add an alternate local-file source, selected by a new HUB_INDEX_PATH env var (or the chart's localIndex.configMapName value), that takes precedence over the existing hubIndexURL fetch. - catalogCache now wraps a source-agnostic fetch func instead of owning an *http.Client directly, so both the HTTP path (fetchRemoteIndex) and the new local-file path (fetchLocalIndex) share the same TTL caching and stale-on-error fallback. This also makes the cache unit-testable without a live server. - The chart mounts the ConfigMap as a directory rather than a subPath file, so updates propagate on the existing cache TTL without a pod restart. - Defaults are unchanged: with localIndex.configMapName empty, no new env var, volume, or mount is rendered. Fixes openeverest#12 Signed-off-by: Anchit-04 <anchit1234deshpande@gmail.com>
Contributor
|
@Anchit-04 thanks! did you test it? how does it handle icons of providers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now plugin-hub always fetches index.json from GitHub, so a cluster with no outbound internet access can never populate its catalog. Add an alternate local-file source, selected by a new HUB_INDEX_PATH env var (or the chart's localIndex.configMapName value), that takes precedence over the existing hubIndexURL fetch.
Fixes #12