Repository navigation
feat: find component pods by the selectors in status.components - #3
Merged
Merged
Conversation
status.components[].podRefs are gone from the Instance API; each component now reports a pod selector instead. Signed-off-by: Diogo Recharte <diogo.recharte@solanica.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finds an instance's pods through the per-component selectors the provider runtime now reports in
status.components(openeverest/openeverest#3335).status.components[].podRefsno longer exist, so the podRefs path was dead code against current core.selector. Every selector is narrowed withcore.openeverest.io/instance=<instance>, so a broad or wrong selector in the status can never reach another instance's pods.engine,proxy,configServer) when the pod has it, falling back toapp.kubernetes.io/componentas before.app.kubernetes.io/instance.Providers: PSMDB already labels its pods (openeverest/provider-percona-server-mongodb#117). PXC and PG follow in openeverest/provider-percona-xtradb-cluster#38 and openeverest/provider-percona-postgresql#45.
Testing
go vetandgo test -race ./...inbackend.backend/go.mod; that also movesgo.yaml.in/yaml/v3to v3.0.5.