Repository navigation
Update actions - #60
Merged
Merged
Conversation
Remove overridden empty destructors.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the supplied evidence.
No open issues 🎉
What changed in this PR
Updates GitHub Actions checkout versions and authentication permissions while cleaning up the C++ load-class hierarchy to address compiler warnings.
Changes:
- Upgraded workflow checkout actions to
actions/checkout@v6. - Granted the versioning workflow
contents: writepermission and removed its personal access token dependency. - Removed redundant destructors and exposed inherited
getTargetoverloads.
| File | Description |
|---|---|
| src/FFlLib/FFlFEParts/FFlLoads.H | Simplifies load-class declarations and resolves inherited getTarget overload visibility warnings. |
| .github/workflows/versioning.yml | Upgrades checkout and enables the built-in write-enabled GitHub token for version commits. |
| .github/workflows/run-test.yml | Upgrades the checkout action used by the test workflow. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisit #53 which was removed after merge, but now with checkout@v6 and some gcc 13 warnings.