Repository navigation
feat: [DATABASE] Room 3 query logs through a logging SQLite driver - #743
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Room 3 has no
setQueryCallback, so its databases never sent their queries to Flocon: the Logs screen was empty for every Room 3 database (only the Room 2 one of the sample logged). This addsSQLiteDriver.floconLogs(id), which wraps the driver given tosetDriver(...)and logs each statement when it runs, with its arguments.Stacked on #742 (the
idis the one the database is registered with): this PR targetsfix/database-logs-by-idso its diff is only the Room 3 part. Retarget it tomainonce #742 is merged.floconLogs(id)indatabase:room3(commonexpect, one implementation for Android / JVM / iOS and onesuspendimplementation for Wasm, where the driver methods are suspend), no-op indatabase:room3-no-op.docs2/database.md.Tested:
:database:room3:jvmTest(4 tests on the wrapper with a fake driver), compilation ofroom3androom3-no-opon Android / JVM / iOS / Wasm, of the four samples, and debug + release builds of:sample:android. Checked on the Android emulator withAndroidSQLiteDriver: inserting a dog shows theINSERT INTO DogEntitywith its arguments inlist_database_query_logsfordogs_room3. The JVM, iOS and Wasm drivers are compiled but not run./gemini review