Repository navigation
feat: [QRSCANNER] Connect by scanning the desktop QR code - #748
Merged
Merged
Conversation
florent37
commented
Oct 31, 2026
florent37
commented
Oct 31, 2026
florent37
marked this pull request as ready for review
October 31, 2026 11:52
florent37
enabled auto-merge (squash)
October 31, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android counterpart of the QR code scan added to FloconSwift: connect to Flocon Desktop by scanning its QR code instead of typing the IP.
SDK (new optional module
flocon-qr-scanner, with its-no-op)Flocon.scanQrCodeAndConnect(context)opens the Google code scanner (a Google Play Services screen: no camera permission, but Play Services is required), then connects. It returns theFloconConnectResult, ornullif the user closes the scanner. A scan failure (for example without Play Services) is aFailed.Flocon.connectWithQrCode(content)connects from the text of a QR code, for an app with its own camera screen. The content is the IP address the desktop puts in its QR, or a URL whose host is that address (scheme, port and path are ignored).:floconmust not pull.Sample: the Android app sets
SampleQrScanner.scan, and the connection screen shows a "Scan the QR code of Flocon Desktop" button when it is set. Release builds use the no-op.Docs:
docs/setup.md, "Connecting with a QR code" (replaces "not available yet").Tests:
QrCodeAddressTest(jvmTest) for the QR content parsing./gemini review
Generated by Claude Code