Repository navigation
refact: [QR] Remove connectWithQrCode, the QR code only holds the IP address - #758
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows the review of the Swift version (FloconSwift#24): the QR code of Flocon Desktop holds only the IP address, so a second connect method is not needed.
SDK (
flocon-qr-scannerand its-no-op)Flocon.connectWithQrCode(content)and the URL parsing (addressFromQrCode) with its test.Flocon.scanQrCodeAndConnectnow callsFlocon.connect(address)with the scanned text (already trimmed there). An app with its own camera screen callsFlocon.connect(address).scanQrCodeAndConnectchecks Google Play Services first: without it (AOSP emulator, Huawei...) it returnsFailed("Google Play Services is required to scan a QR code: connect with the IP address instead")without opening the scanner.Docs:
docs/setup.md, "Connecting with a QR code" documents the scanner module, the Play Services requirement and the fallback.Checked locally:
:qrscanner:qrscanner:jvmTest,:sample:android:assembleDebugandassembleRelease.mkdocs build --strictnot run (mkdocs not installed here)./gemini review