Skip to content

[Feature]: Change to the color button in the Drawing group #1298

Closed

Description

@arielsrossi

Before you start

What problem does this solve?

In the Drawing group, there is a "Color" option located above the "Outline" and "No Fill" buttons.
Therefore, "Color" should change the color of the outline, not the fill.

Image

Proposed solution

Just one button "Full Fill"

Estimated scope

Small: a minor tweak, small UI change, or text adjustment

Alternatives considered

No response

Activity

  1. ninhhaidang commented on Nov 11, 2026

    @ninhhaidang
    Member

    I'd like to take this one.

    I read how the "Color" button works (layer.color, crates/engine/src/cmd/layer.rs). On a polygon layer it changes only the fill, and the outline colour is left alone (the ribbon only has an outline width). On a point layer it also changes only the marker's fill. On a line layer it sets the line's colour. So you're right that "Color" next to "Outline" and "No Fill" reads as the outline colour when it isn't.

    My plan is to rename the label by geometry: Fill for polygon and point layers, and keep Color for line layers, where there is no fill. That is a label change only, with before/after screenshots in the PR.

    Did you mean something different by "Full Fill", for example one combined fill control, or a separate outline-colour button? If so, I'll do that instead.

  2. ninhhaidang commented on Nov 16, 2026

    @ninhhaidang
    Member

    Thanks for testing. The change from #1784 is in v0.7.0: on a polygon or point layer the Drawing group's button now reads Fill. I installed v0.7.0 on a separate Mac and it shows "Fill" there.

    A line layer still shows Color, since a line has no inside; and a layer with several geometry kinds may too. Could you tell me the layer type you selected, whether the app is set to English, and the version shown in Help › About? If it still says "Color" on a polygon layer, a screenshot would help.

  3. arielsrossi commented on Nov 16, 2026

    @arielsrossi
    Author

    Thanks for testing. The change from #1784 is in v0.7.0: on a polygon or point layer the Drawing group's button now reads Fill. I installed v0.7.0 on a separate Mac and it shows "Fill" there.

    A line layer still shows Color, since a line has no inside; and a layer with several geometry kinds may too. Could you tell me the layer type you selected, whether the app is set to English, and the version shown in Help › About? If it still says "Color" on a polygon layer, a screenshot would help.

    I’m going to open a new issue, referencing this PR, to demonstrate the problem.

    Attached is the video demonstrating the problem.
    https://drive.google.com/file/d/1bE-VKng2hh-b8xp5rKC9C3wjfB8HChIc/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions