Skip to content

[Bug]: GeoRSS reader silently drops unreadable polygon holes (interior rings) #2048

Closed

Description

@TalhaHunter101

Before you start

  • I searched the existing issues and did not find a duplicate.
  • This is a bug report, not a usage question.

What happened?

When reading a GeoRSS feed containing a GML polygon (georss:where with gml:Polygon), any unreadable or malformed gml:interior rings (e.g. invalid coordinates or fewer than 4 points once closed) are silently dropped without being counted or reported in ReadReport.messages.

This silent data loss was noted in ROADMAP.md:

the KML and OSM readers leave out unreadable coordinates, holes and parts without one, and GeoRSS its unreadable holes (GML says so since #1686) (open).

Per AGENTS.md ("Never silent"):

A reader, writer, tool or command that drops, truncates or approximates data says what, how much and where: Z values dropped, field names cut, a CRS assumed, features skipped.
Existing silent losses are bugs.

Steps to reproduce

  1. Read a GeoRSS XML feed with a gml:Polygon containing a malformed gml:interior ring via rustgis_data::georss::read.
  2. The outer boundary is parsed and kept as a polygon feature.
  3. The invalid interior ring is silently omitted without notice in report.messages.

Expected behavior

When an interior ring cannot be parsed, the reader should record and report the loss in ReadReport.messages (e.g. 1 hole in a polygon was unreadable and left out), consistent with GML reader reporting (#1686).

How are you running RustGIS?

Command line (rustgis-cli)

Version

main (0eeb756)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions