Skip to content

Check Cancel during analysis preparation and group statistics #2178

Closed

Description

@giswqs

Two analysis preparation/statistics paths still process growing input without an item-level cancellation check on main d03c1a57:

  • Dissolve checks once per group, then orders records, counts text values and calls statistic_values. That shared helper materializes columns and computes statistics without checking Cancel. A large single group can therefore continue scanning or sorting after cancellation.
  • Split groups its zones and prepares lookup/index state before the later per-item workers. The grouping loop in split_on does not check Cancel, although its API documentation says preparation is checked item by item.

Make these shared loops cancellation-aware, with progress where measurable, while preserving deterministic output and leaving no result or undo step after cancellation. Add deterministic regressions that cancel during the preparation/statistics phase, rather than only before the tool starts. Document any remaining indivisible sorting or geometry step.

Release sweep sources: #1670 (comment) and #1674 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions