Skip to content

Refresh terrain water levels after a failed detailed shore tile uses an ancestor #2200

Closed

Description

@giswqs

crates/render/src/terrain.rs::tile_height returns a coarser ready ancestor after the requested detailed tile fails. The failed branch does not set pending; water shoreline sampling sees Some(height) and leaves missing false. Water::build consequently stores retry=None, keeping the ancestor-derived level until the layer/DEM/zoom/encoding cache key changes, even after the detailed tile recovers.

Carry detail/failure provenance separately from the returned usable height and schedule a later shore refresh. Keep cache back-off honored and report the approximation consistently. Regression: failed zoom-N tile + ready ancestor gives a usable temporary level and a retry; after recovery the detailed shore level replaces it. Also cover a wholly ready shore with no retry.

Verified source on ce40749 in release sweep. Sources:

Duplicate search: all-state water ancestor returned no issue; #1915 is the broad water feature tracker. This is separate from the bounded allocation fix in #2194.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions