Skip to content

Reader accounting: conversion losses, geometry versions and nested properties #2202

Closed

Description

@giswqs

Release-sweep source review found four remaining reader-accounting gaps on main (ce40749). These need regressions and an agreed compatibility policy before changing the read paths.

  • GDAL repaired/reloaded conversions: source/gdal.rs::convert_one returns only Conversion.path, and convert_one_fresh_in carries driver/Z/M diagnostics without the source-count versus indexed FlatGeobuf count comparison used by convert_in. An empty polygon that GDAL omits can therefore be counted on initial Add but omitted from a later repair/reload report. Reuse the comparison with correct handling of a selected geometry family, and cover initial read, cache hit, repaired conversion and reload, including mixed-family sources. Deferred source comment.

  • GeoPackage geometry header versions: source/gpkg_blob.rs::is_whole_empty_blob checks version zero, but split_blob does not check the version byte on a non-empty GP geometry. Decide how the source reports a newer version before decoding its header as version zero; exercise native and browser whole/chunked reads. A newer geometry encoding must be refused or retained without rewriting it as if fully understood.

  • Nested TopoJSON geometry properties: topojson.rs::read_with reads attributes for each top-level feature member, while rebuilding a nested GeometryCollection follows only its geometry. Properties on a nested geometry can therefore disappear when the collection is reduced to supported geometry. Add a nested-property fixture, then preserve or explicitly report those values according to the collection policy. Review source.

  • Nonfinite Web Mercator WKT unit/axis: raster/wkt.rs::is_web_mercator checks UNIT and the semi-major axis through finite-number accessors followed by is_none_or. A present nonfinite value therefore follows the absent-value default, while nonfinite PARAMETER values already have a refusal guard. Distinguish absent from malformed/nonfinite unit and spheroid values, and add explicit malformed-WKT regressions. Review source.

Duplicate search checked open and closed GDAL repair issues, #1998 and the broader #2008 audit. This issue narrows the unaddressed paths; other findings already tracked there should stay there. This is a source-confirmed follow-up, not a claim that runtime reproductions have been completed.

Activity

  1. changed the title [-]Reader accounting: GDAL repair loss counts and GeoPackage geometry versions[/-] [+]Reader accounting: conversion losses, geometry versions and nested properties[/+] on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions