Skip to content

test: dropped_z_values_are_said_on_import_and_export fails on main since #2196 (streamed export now relays the reader's Z/M note) #2238

Closed as not planned

Description

@elpidioassinaturas

tests::dropped_z_values_are_said_on_import_and_export (crates/engine) fails on main since e345761 (#2196), so the Linux test / Test (ubuntu-latest) job is red on every pull request merged with current main (seen on #2234 and #2235, neither of which touches exports). Reproduced locally on Windows too.

What fails

The streamed case ("stream": true) of the share.exportLayer step asserts the generic export notice:

its geometry has no Z or M values, which were dropped when wells was read

Since e345761, write_layer relays the whole read's diagnostics (read_notes) and coalesce_read_zm drops the generic note when the reader counted its Z/M loss (lost.zm_noted). So the export now says the reader's message, prefixed with the output path:

…/out-true.geojson: wells: 1 feature had Z or M values (heights or measures), which were dropped: RustGIS keeps x and y only, so exports won't have them

The panic, at crates/engine/src/tests.rs:23018 on main:

stream true: [Notice { text: ".../out-true.geojson: wells: 1 feature had Z or M values (heights or measures), which were dropped: RustGIS keeps x and y only, so exports won't have them", ... }, Notice { text: "Exported .../out-true.geojson", ... }]

The stream: false case and data.convert still get the generic note.

Proposal

The new behaviour is the intended one (one Z/M note per export, the counted one when the reader has it), so update the test rather than the code: in the streamed case, accept the reader's counted note for the output file (contains the output path and Z or M values), and keep the generic wording for the whole-read case. If both cases should read the same, the alternative is to coalesce the other way (keep the generic note and drop the relayed reader one), but that loses the feature count.

Repro: cargo test -p rustgis-engine --lib dropped_z_values_are_said_on_import_and_export

Activity

  1. elpidioassinaturas commented on Nov 15, 2026

    @elpidioassinaturas
    ContributorAuthor

    Already fixed by #2231 (merged 22:03 UTC), which updated the test for the counted loss notices. Closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions