Repository navigation
fix(layout): draw a legend's points as the map does #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jgregoriorincon
merged 32 commits into
opengeos:main
from
jgregoriorincon:fix/legend-symbol-fidelity
Nov 5, 2026
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
93128e0
fix(layout): draw a legend's points with the map's marks
jgregoriorincon 60a8913
fix(layout): apply transparency to a legend's points
jgregoriorincon bd60ec8
fix(layout): grow a legend's rows to hold large points
jgregoriorincon 309c3eb
fix(layout): scale a legend's points with the reference scale
jgregoriorincon f32ed45
fix(layout): draw a legend class's own stacked marks
jgregoriorincon 2c295e7
docs(layouts): say how a legend draws point symbols
jgregoriorincon d9b46cd
test(layout): cover a legend's widened column and class rows
jgregoriorincon 27275aa
style(layout): wrap a legend comment
jgregoriorincon 2880524
fix(layout): keep an oversized legend point inside its row
jgregoriorincon f56a483
docs(layouts): rewrap the legend paragraph
jgregoriorincon 9842484
test(layout): allow for rounding in a legend's size
jgregoriorincon b148f80
docs(layouts): say what a legend does with large points
jgregoriorincon 9acf472
fix(layout): draw a legend's plain point with the map's marker
jgregoriorincon 5a8f965
fix(layout): keep a see-through point's picture on the canvas
jgregoriorincon d292773
refactor(layout): read a legend row's symbol only for a point
jgregoriorincon 3fcf22e
refactor(symbology): take a legend row's class strokes from one place
jgregoriorincon 162e33d
docs: describe the legend's functions
jgregoriorincon a6feefe
test(layout): check a recorded legend's point, its cut and its opacity
jgregoriorincon fd3e7ff
test(symbology): check a class's strokes with its classes stored in a…
jgregoriorincon a40f9c4
docs(layouts): rewrap the legend paragraph
jgregoriorincon f577e47
docs(layouts): say what a legend's symbol leaves out
jgregoriorincon 651ecc4
fix(render): reach the corners of a mark with its own angle
jgregoriorincon 3d1faaa
refactor(layout): name a legend row's strokes apart from a renderer's
jgregoriorincon 6498793
docs(layout): say what else limits a legend's side
jgregoriorincon ab56d8b
test(layout): compare a see-through plain point with the map's
jgregoriorincon 7571363
docs: describe the legend's tests
jgregoriorincon c74b39f
docs(layouts): split the legend's paragraph into its parts
jgregoriorincon dea3680
test(layout): drop a needless struct update
jgregoriorincon eb8b46d
Merge branch 'main' into fix/legend-symbol-fidelity
jgregoriorincon 8a3d21c
fix(map): give a diagram's legend rows their own mark
jgregoriorincon a2c061b
fix(layout): cut a recorded point at its box
jgregoriorincon ba8d710
test(layout): check an upright mark stays in its row
jgregoriorincon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.