Repository navigation
feat(ui): links in the identify pop-up, and pictures from the asset server or on click #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,581
−26
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
daeec2b
feat(ui): links in the identify pop-up, and pictures from the asset s…
PawelKra 606da73
fix(ui): a slash in a link's query doesn't make it a picture address
PawelKra be9d68f
fix(ui): the pop-up prefers a picture it can fetch, and names a forma…
PawelKra 94cb14f
fix(ui): pop-up pictures go with a sign-out, and their header is read…
PawelKra bafe036
Merge remote-tracking branch 'upstream/main' into feat/popup-links-pi…
PawelKra 847ec90
fix(identify): give metadata addresses their own reason, fit pictures
giswqs de1f824
fix(identify): drop sign-out pictures on every frame
giswqs 6d084c6
fix(identify): orient pictures, repaint on cache clear
giswqs 62aa4ac
Merge remote-tracking branch 'upstream/main' into feat/popup-links-pi…
PawelKra 33a02fe
Merge branch 'main' into feat/popup-links-pictures
giswqs 265fe89
Merge remote-tracking branch 'upstream/main' into feat/popup-links-pi…
PawelKra 2046c90
docs(ui): say the web app refuses a picture's redirect
PawelKra d5656f8
fix(web): give up a pop-up picture that stalls, as tiles are
PawelKra e003a7d
Merge branch 'main' into feat/popup-links-pictures
giswqs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs / PR description (confidence: high). Further down this request (line 687, outside this diff) sets
RequestRedirect::Manualfor a request without a login, orErrorwith one.check_redirect(around line 988) then turns the opaque redirect into an error. So in the web app a picture download never follows a redirect. That matchesdocs/privacy.mdanddocs/user-guide/editing.md, which say the web app refuses one.The PR body still says "In the web app the browser follows redirects and resolves names", and the earlier reply on the redirect thread says "In the web app the browser's fetch follows it". Both are out of date. Please correct the PR description before merge, since it is the privacy description. No code change is needed; refusing is the safer behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, corrected the PR description: in the web app a picture download refuses a redirect, and the browser resolves names, so only the address as written is checked there. Also added a correction to the earlier reply on the redirect thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude autofix (unclear): The code matches this comment: the web fetch sets
RequestRedirect::ManualorError(apps/rustgis-web/src/web.rs:687), andcheck_redirect(web.rs:988, called at web.rs:726 and 958) refuses the opaque redirect. The PR description still needs correcting, which is for the author to edit; this change does not touch it.