Repository navigation
fix(ui): test authenticated service connections before saving #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
89a9eb6
fix(ui): test authenticated service connections before saving
deniial00 685f7e2
fix(ui): protect connection test feedback and credential history
deniial00 e71e60e
Merge remote-tracking branch 'origin/main' into fix-wmts-test-before-…
deniial00 bda1c27
fix(tiles): prioritize explicit service logins over S3
deniial00 0275a50
fix: protect abandoned service tests
deniial00 c764cbe
fix: redact rejected authenticated redirects
deniial00 81dfa25
Merge branch 'main' of github.com:opengeos/RustGIS into fix-wmts-test…
deniial00 b5cc1e2
fix(engine): log a response size once
deniial00 6f8a399
Merge commit '6cae5e902f357dd35db50f4ae4e152ffdb3f36e7' into fix-wmts…
deniial00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance: every authenticated Test teardown wipes the whole tile cache (medium confidence).
logins::deactivatecallscrate::cache::clear()when it removes a binding. That function keeps only Pending slots and then clears the sources, sprites, PMTiles, MBTiles, COG and warp caches. So each time an unsaved authenticated Test is dropped, after its result, on edit, on cancel, or when a project changes, every public basemap tile in the open map is evicted and re-downloaded.The existing saved-login revocation has the same effect, but this PR adds a new, frequent trigger. Scoping the clear to entries bound to this login, or deferring it to the next frame, would avoid it. This is a performance concern, not a correctness one. The
Dropordering and lock release are fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left for the release quality pass: scoped cache eviction is a performance redesign beyond the existing safe login-revocation mechanism (reviewed at e71e60e).