Repository navigation
fix(ui): the identify pop-up's picture formats don't depend on the build's decoders #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deniial00
merged 2 commits into
opengeos:main
from
deniial00:fix/popupmedia-decoder-caps
Nov 9, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -226,8 +226,9 @@ such as `image_page_url` or `image_credit` stay links or text in the list. | |
| A picture from RustGIS's own asset server (`https://assets.rustgis.app/…`) is fetched as the pop-up | ||
| opens. A picture from any other server isn't: the pop-up shows **Show Picture** and the server's | ||
| name, and fetches nothing until you click it, because the request tells that server that someone | ||
| opened the data (see [Privacy](../privacy.md)). A spinner shows while a picture is fetched. Pictures | ||
| of up to 4 MB and 2048 × 2048 pixels are shown; the last 16 addresses' pictures are kept for the | ||
| opened the data (see [Privacy](../privacy.md)). A spinner shows while a picture is fetched. PNG, JPEG, | ||
| WebP and GIF pictures of up to 4 MB and 2048 × 2048 pixels are shown (on every platform; any other | ||
| format, such as BMP or TIFF, is "not supported"); the last 16 addresses' pictures are kept for the | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: the text quotes "not supported", but the message the code produces is "Picture unavailable: BMP pictures aren't supported". Quoting the real wording would let a user match the doc to what they see. Left for the release quality pass. |
||
| session, so opening the pop-up again shows the picture without asking again; they are forgotten with | ||
| the web layers' cached tiles (signing out of ArcGIS, a login that ends, **Reload Web Layers**). When | ||
| one can't be shown, the pop-up says why ("Picture unavailable: …": the server's answer, a network | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.