Repository navigation
fix(analysis): Minimum Bounding Geometry looks at Cancel with Group: All #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7c9a454
fix(analysis): Minimum Bounding Geometry looks at Cancel with Group: All
flight1973 b7bc86c
fix(analysis): Group: All gathers points through try_map; its count e…
flight1973 88d35e2
fix(analysis): Group: All hulls each feature, then hulls their hull p…
flight1973 8ab213d
fix(analysis): convex_hull keeps its doc comment; test the Group: All…
flight1973 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage (medium-low confidence): this PR newly puts Group: All on
parallel::try_map(threaded at 256+ features), but no test checks it against the one-thread result. The only parallel-vs-serial check,per_feature_tools_on_several_cores_keep_each_features_result(around line 6800), covers Group: None. AGENTS.md asks that split work give the same output as one thread, bit for bit.A small addition would close the gap: build more than
PARALLEL_FEATURESfeatures with varied rings, runconvexHullwithgroup: "All", and compare the output with a run that forces one thread. Because the output ring can start at a different corner, compare the corner sets, or the exact output if the code order is deterministic.Left for the release quality pass if the maintainers prefer, but the new path has no such check yet.