Repository navigation
fix(extensions): let go of a refused run's raster and its section's pick (#1752) #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug (medium confidence): a blocked command drops another caller's pending raster before any owner check.
authorizeruns for every ingress, including scoped ones (assistant, MCP, plugin, viawith_scope), with the caller's rawparams. This newretainremoves the raster whose id is inparams["ran"]without checkingcontinuation_owner.finish_rasterandauthorize_uncheckedboth check ownership before touching that raster, so this line is the only path that doesn't. A scoped caller can send any command of an extension that is off with"ran": Nand delete a pending raster it doesn't own. Run ids come from a sequential counter, so they are easy to guess. The effect is limited (the owner gets "no longer kept: run it again"), but it is a cross-caller state change on a path that used to have none.Also, the removal is not mentioned in the returned error, so the drop is not reported.
Suggested fix: drop the raster only when its owner is the caller.
No regression test covers either this path or the new analysispane clearing. Please add one for each, since the PR changes behavior.