Repository navigation
fix(tiles): an export waits for an MBTiles file's metadata as for its tiles #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible lost wake-up (confidence: moderate, ~40%).
drop(under_way)runsfinished(), which bumps the generation, decrementsIN_FLIGHTand wakes the map, all beforepending.removeandready.notify_all(). The old trailingcrate::cache::notify()(which came after the removal) is also gone, so the last wake now comes before the key leaves the pending set.When
remember_infodoesn't store the result (the epoch moved, orcheck_stillrefused, as the test atmbtiles.rs:475arranges), a render woken by that bump can run in the gap and see the key still pending.info_readythen returnsOk(None)and nothing wakes the map after the removal. The export loop recovers because its next render re-spawns the read. The interactive map has no such recovery in this path.Dropping the count last fixes the ordering: anyone who sees
in_flight() == 0also sees the read off the pending set, and the final wake follows the removal.