Repository navigation
fix(render): #1782 follow-ups 2: an export says only its last pass's cast-shadow notices, the tilted wait test holds the worker #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
giswqs
merged 3 commits into
opengeos:main
from
elpidioassinaturas:fix/1782-followups-2
Nov 12, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
3393db9
fix(render): an export says only its last pass's cast-shadow notices …
elpidiofilho 69e4139
test(render): the tilted wait test waits for the export's own signal …
elpidiofilho 7c84165
test(render): the tilted wait test fails, not hangs, after 30 s (#1782)
elpidiofilho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The polling loop has no bound, so a regression can hang the test instead of failing it (confidence: medium). The loop exits only when the export has a waiter registered or has finished. If a future change makes the export block on some path that doesn't go through
Waiting::onwhile the hold is held, neither condition ever becomes true. The test then spins forever and CI times out rather than reporting the failure.A deadline doesn't weaken the check.
waitedis still read from the count after the loop, so a timeout with no waiter still fails the assertion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7c84165: the loop now fails after 30 s, saying the export neither waited for the grid nor ended.