Repository navigation
fix(settings): keep saved sources, plugin state and sign-ins a newer RustGIS wrote #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mavrick-F
merged 17 commits into
opengeos:main
from
Mavrick-F:fix/settings-preserve-sources-plugins
Nov 14, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3f9d938
fix(settings): keep saved sources, plugin state and sign-ins a newer …
Mavrick-F af475cf
fix(settings): refuse before changing a plugin, keep a web plugin's u…
Mavrick-F 5c1205a
fix(settings): say what cleaning changed in an address, keep stored s…
Mavrick-F 7a72ab7
fix(settings): classify a source's unknown fields on the whole object…
Mavrick-F 6525bd4
fix(settings): a source listed twice is one source, merged at load; a…
Mavrick-F ea1a7f2
fix(engine,assistant): count cleared login bindings, refuse odd store…
Mavrick-F 88fccc4
Merge upstream/main into fix/settings-preserve-sources-plugins
Mavrick-F add3f83
fix(plugins): load no plugins while state.json can't be read
Mavrick-F b3f2e37
Merge upstream/main into fix/settings-preserve-sources-plugins
Mavrick-F d81b76d
fix(engine,ui): forgetting a source drops its kept over-limit row; co…
Mavrick-F 54e3bc6
refactor(engine): one identity for saved sources; a repeated row is d…
Mavrick-F d71cb05
fix(plugins): an empty state.json is nothing disabled, as a missing one
Mavrick-F 8bc93e0
fix(engine): forgetting a source kept only past the list's limit coun…
Mavrick-F eda708f
fix(engine): check kept fields again when a source's details change; …
Mavrick-F 4adf225
fix(engine, plugins): say a secret left out when a source changes; a …
Mavrick-F a0a78ae
fix(engine): every way of recording a recent source says a secret it …
Mavrick-F 073592c
fix(engine, plugins): a byte-order mark in saved sources reads as JSO…
Mavrick-F File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never silent (low-medium confidence): a newer store reads as signed out with only a log line. This refusal reaches
load_any_at, which onErrcallslog::warn!and then falls back toread_accounts(path).ok()?. That fallback fails again for a newer store, soload()returnsNone. The account looks signed out, and the reason only appears if the user tries to sign in.log::warn!doesn't count as a notice under AGENTS.md.Suggested fix: report the refusal to the user through
Session::notifyor the existing error path, once per session, from the code that callsload()for UI state. Add a test that the newer-version refusal is shown where the user sees it, not only in the log.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changed in this round: a refused or newer store reaches the user only through the log because
load_anyreturns anOptionto its callers (the assistant pane reads it on a worker). Showing it as a notice needs a new way to carry the refusal out ofchatgpt, which is more than a local change here; the maintainer will decide whether it is done here or separately.