Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
| let inner = vec![vec![(1.0, 1.0), (2.0, 1.0), (2.0, 2.0), (1.0, 2.0)]]; | ||
| assert!(!triangulate_reporting(&sq, &inner).unwrap().1); | ||
| // A hole that stays clear of the left side is fine. | ||
| // A hole touching the left side at points, without sharing an edge, is fine. |
There was a problem hiding this comment.
Comment is wrong about the fixture (confidence: high). The hole (0,1), (2,2), (0,3) has its closing edge (0,3)→(0,1) on x = 0, which is the square's left side. So the hole shares a 2-unit segment with the outer ring; it does not touch "at points without sharing an edge". The assertion (not fanned) is pre-existing and unchanged, so the test still checks the shared-segment case. The PR body's stated purpose is the points-only case, which this fixture does not exercise. Suggested wording that matches what the test checks:
| // A hole touching the left side at points, without sharing an edge, is fine. | |
| // A hole sharing part of the left side, from (0,1) to (0,3), is not fanned. |
If the points-only case is what you want covered, it needs a separate fixture whose hole vertices sit on x = 0 without a hole edge between them.
Code reviewBugs
Security
Performance
Quality
AGENTS.md
Prior reviews: none on this PR, so nothing was skipped as already raised. Change sizeCompared: the whole PR against main (merge base ce40749 to PR head 3f1fecf).
|
|
Superseded by the combined release-quality PR #2196 so these related fixes can be reviewed together. |
Summary
Pin the negative half-tie area-formatting behavior and correct the triangulation fixture comment: the hole touches the left edge at points without sharing an edge.
Release quality points: negative half-tie, touching-hole fixture.
Testing
Formatting and diff checks passed.
cargo test -p rustgis-geomis running; long checks continue in CI. Local validation uses GDAL 3.13.3.UI evidence
No visible UI change.