Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Superseded by the combined release-quality PR #2196 so these related fixes can be reviewed together. |
| /// whole-number type), or see-through for a colour image with neither alpha nor no-data, which | ||
| /// gains an alpha band for it. | ||
| /// the pixel under its centre. Cells off the raster are its no-data (else NaN, or 0 in an | ||
| /// unlabelled whole-number type). A band with class names makes outside cells NaN in every band. |
There was a problem hiding this comment.
The new second sentence is stated without its condition. In Canvas::of, outside cells take the raster's no-data value when it has one (outside = r.nodata.map_or(none, …)), so a labelled band with no-data gets that value, not NaN. The NaN case only holds when there is no no-data value.
| /// unlabelled whole-number type). A band with class names makes outside cells NaN in every band. | |
| /// unlabelled whole-number type). With class names and no no-data value, outside cells are NaN in every band. |
Code reviewBugs
Security
Performance
Quality
AGENTS.md
Prior reviews: Change sizeCompared: the whole PR against main (merge base ce40749 to PR head 48f9b36).
|
Summary
Identify the overlay plane in Clip's retained-sliver notice, skip the bounding-box pass for rings that cannot be oriented, and add grouped convex hulls to the serial/threaded equivalence matrix. Correct the warp API description of NaN padding for named-class rasters.
Release quality points: sliver area wording, unwrapped ring span, grouped hull equivalence, warp padding documentation.
Testing
UI evidence
Inspected before/after screenshots are being attached directly to this PR.