Skip to content

fix(analysis): clarify overlay measures and cover grouped hulls - #2188

Closed
giswqs wants to merge 1 commit into
mainfrom
fix/sweep-analysis-quality-2026-11-15
Closed

giswqs wants to merge 1 commit into
mainfrom
fix/sweep-analysis-quality-2026-11-15

Conversation

@giswqs

@giswqs giswqs commented Nov 15, 2026

Copy link
Copy Markdown
Member

Summary

Identify the overlay plane in Clip's retained-sliver notice, skip the bounding-box pass for rings that cannot be oriented, and add grouped convex hulls to the serial/threaded equivalence matrix. Correct the warp API description of NaN padding for named-class rasters.

Release quality points: sliver area wording, unwrapped ring span, grouped hull equivalence, warp padding documentation.

Testing

  • Analysis tests passed during the initial workspace validation run, including the threaded/serial property. That run later stopped at the unrelated Assistant documentation-catalog failure fixed by fix(assistant): bundle the moved GeoLibre parity checklist #2180, which is included here.
  • Inspected actual before/after headless app captures of Clip on the boundary-sliver regression data. The notice now explicitly says area in the overlay plane.
  • Formatting and diff checks passed; long checks continue in CI. Local validation uses GDAL 3.13.3.

UI evidence

Inspected before/after screenshots are being attached directly to this PR.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bccfef1f-2026-4357-a55d-0ad949e6fbb0
Commits

Reviewing files that changed from the base of the PR and between ce40749 and 48f9b36.

Files selected for processing: 3

  • crates/analysis/src/tools.rs
  • crates/analysis/src/warp.rs
  • crates/analysis/tests/parallel_serial.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@giswqs

giswqs commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

Superseded by the combined release-quality PR #2196 so these related fixes can be reviewed together.

@giswqs giswqs closed this Nov 15, 2026
/// whole-number type), or see-through for a colour image with neither alpha nor no-data, which
/// gains an alpha band for it.
/// the pixel under its centre. Cells off the raster are its no-data (else NaN, or 0 in an
/// unlabelled whole-number type). A band with class names makes outside cells NaN in every band.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new second sentence is stated without its condition. In Canvas::of, outside cells take the raster's no-data value when it has one (outside = r.nodata.map_or(none, …)), so a labelled band with no-data gets that value, not NaN. The NaN case only holds when there is no no-data value.

Suggested change
/// unlabelled whole-number type). A band with class names makes outside cells NaN in every band.
/// unlabelled whole-number type). With class names and no no-data value, outside cells are NaN in every band.

@github-actions

Copy link
Copy Markdown
Contributor

Code review

Bugs

  • None found. The ground_area_perimeter change is behaviour-preserving: the old condition was orientable && wide, and wide now includes orientable. Bounding-box work is skipped for non-orientable rings, and the result is unchanged. Confidence: high.
  • The Clip notice now says "in the overlay plane". That matches clip_part, which measures the projected whole.unsigned_area(), and matches docs/user-guide/analysis.md. Confidence: high.

Security

  • None found in the changed lines. Confidence: high.

Performance

  • None found. Confidence: high.

Quality

  • crates/analysis/src/warp.rs:457: the new sentence "a band with class names makes outside cells NaN in every band" is unconditional. When the raster has a no-data value, outside cells take that value instead. Inline comment posted with a suggested fix. Confidence: high.
  • ground_area_perimeter: wide now means "orientable and wider than 180°", so the name no longer matches its meaning. A rename, such as wide_orientable, would be clearer. Wording and naming point, so it can wait for the release quality pass. Confidence: medium.

AGENTS.md

  • The Clip notice is user-visible, and AGENTS.md asks for before/after screenshots for visible changes. The PR body says screenshots "are being attached directly to this PR". I can't see attachments from here, so please check they are in the PR before merge. Confidence: medium.
  • The new convexHull case with group: "All" is valid. The polygons layer is 240–290 features, so it crosses the 256-feature threshold and reaches the threaded try_map path. The test addition is meaningful. Confidence: high.
  • No new unwrap, expect, panic, or unsafe. No new background work, so the cancel-test lists don't need changes. Confidence: high.

Prior reviews: prior-reviews.json has no threads, so I didn't leave out any earlier concerns.

Change size

Compared: the whole PR against main (merge base ce40749 to PR head 48f9b36).

Measure Value
Files changed 3 (0 added, 3 modified, 0 removed, 0 renamed)
Size before 940.0 KB
Size after 940.2 KB
Total size change +226 B
Path Before After Change
crates/analysis/src/tools.rs 843.8 KB 843.9 KB +68 B
crates/analysis/src/warp.rs 83.0 KB 83.1 KB +64 B
crates/analysis/tests/parallel_serial.rs 14.1 KB 14.2 KB +94 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant