Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Superseded by the combined engine correctness PR #2201. |
Code reviewI found no correctness bugs in the change. I checked the new self-link accounting, the early Bugs
Security
Performance
Quality
AGENTS.md
No prior review threads exist on this PR, so there were no earlier concerns to leave alone. Change sizeCompared: the whole PR against main (merge base ce40749 to PR head f43f876).
|
Summary
A relationship linking a feature to itself now consumes one chart node, including the final free slot. Previously the capacity check counted both endpoints, so 3,000 independent self-links stopped at 2,999 nodes and links with an unnecessary truncation notice.
Once the node budget is full, an origin absent from the chart now skips its destination scan. Existing origins still scan for links to existing chart nodes. This avoids a potentially quadratic rejected-candidate pass after saturation without changing the count of omitted relations.
The capacity regression now covers 3,000 distinct self-links and expects every node/link, without a truncation notice.
Sweep findings: distinct endpoints, duplicate report, saturated destination scan.
Testing
git diff --check.UI evidence
Before/after evidence for the exported chart at its node limit is pending. The ordinary chart appearance is unchanged.