Repository navigation
docs(tiles): clarify observed reach and malformed geocoder replies #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -255,6 +255,8 @@ impl Geocoder { | |||||||||||
| found.limited = entries.len().saturating_sub(i); | ||||||||||||
| break; | ||||||||||||
| } | ||||||||||||
| // An overlong label is a malformed Census response, not a candidate with no usable | ||||||||||||
| // position: refuse it whole rather than shorten or substitute its matched address. | ||||||||||||
|
Comment on lines
+258
to
+259
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment overstates the behaviour (Quality, confidence: high). The check sits after the Suggested wording that matches the code:
Suggested change
The cap-ordering case is also untested: the test near line 480 only puts the overlong label at position 1. Per AGENTS.md this is a wording point, so it can wait for the release quality pass if the author prefers; the current text is still inaccurate. |
||||||||||||
| if self.kind == Kind::Census | ||||||||||||
| && e.get("matchedAddress").and_then(Value::as_str).is_some_and(|name| name.chars().nth(500).is_some()) | ||||||||||||
| { | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (Quality, confidence: high). This is a constructor, so "this does not narrow a previous origin" has no previous origin to refer to. The PR's point is that it is not a narrowing operation, so saying so with the right method is clearer:
Optional, and it can wait for the release quality pass.