Skip to content

refactor(touch): remove unused average-accuracy calculation - #2192

Closed
giswqs wants to merge 1 commit into
mainfrom
sweep/touch-average-cleanup-2026-11-15
Closed

giswqs wants to merge 1 commit into
mainfrom
sweep/touch-average-cleanup-2026-11-15

Conversation

@giswqs

@giswqs giswqs commented Nov 15, 2026

Copy link
Copy Markdown
Member

Summary

Remove the mean-accuracy field from the touch position average: the form never displays or reads it. Averaging retains its weighted coordinates, spread and sample count, while avoiding a separate unused pass over fixes. Existing assertions still verify the weighting and missing-accuracy behavior.

Deferred review point: unused average accuracy.

Testing

  • cargo fmt --all --check and git diff --check pass.
  • Focused touch validation and long workspace checks are pending; this PR is submitted before long-running tests finish, as requested.
  • Sweep validation uses GDAL 3.13.3.

UI evidence

No visible UI change.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1f87c6c3-56ec-4731-9da0-e422d2b4f174
Commits

Reviewing files that changed from the base of the PR and between ce40749 and 1207dde.

Files selected for processing: 1

  • crates/ui-touch/src/track.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@giswqs

giswqs commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

Superseded by the combined release-quality PR #2196 so these related fixes can be reviewed together.

@giswqs giswqs closed this Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Code review

Reviewed the one-file change to crates/ui-touch/src/track.rs, which removes the unused mean-accuracy field from track::Average. I checked the struct, its only constructor in average(), and every reader in crates/ui-touch/src/lib.rs and track.rs. Nothing reads Average.accuracy anymore, and the weighting, spread, count and None paths are unchanged. I could not compile or run the tests in this review (no shell), so the compile-safety conclusion comes from reading the code.

Bugs

  • None found. The removed field has no remaining readers, so the struct and tests still compile by inspection. Confidence: high.

Security

  • None found.

Performance

  • None found. The change drops one extra pass over fixes that summed Option<f64> accuracies. The saving is negligible for capture-sized inputs, but the change is strictly less work. Confidence: high.

Quality

  • None found. The test edits match the removed behaviour, and the comment update ("all count the same.") is accurate. Confidence: high.

AGENTS.md

  • None found. The change adds no unwrap, expect, panic, indexing or unsafe, adds no user-visible strings, and adds no I/O or long-running work.

Prior review threads: none on this PR, so no earlier concerns were left alone.

Change size

Compared: the whole PR against main (merge base ce40749 to PR head 1207dde).

Measure Value
Files changed 1 (added 0, modified 1, removed 0, renamed 0)
Size before 24.4 KB
Size after 24.1 KB
Total size change -326 B
Path Before After Change
crates/ui-touch/src/track.rs 24.4 KB 24.1 KB -326 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant