Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ce7c635
fix(geolibre): check Cancel before starting the runner
giswqs Nov 15, 2026
709b4ce
test(geom): cover negative half ties and clarify touching holes
giswqs Nov 15, 2026
70e9e76
fix(mobile): reject an empty native-library alignment check
giswqs Nov 15, 2026
2623f56
fix(analysis): clarify overlay measures and cover grouped hulls
giswqs Nov 15, 2026
7beede4
fix(map): align legend warnings and grid aliases with their data
giswqs Nov 15, 2026
ed8b375
docs(tiles): clarify observed reach and malformed geocoder replies
giswqs Nov 15, 2026
4ea46a7
refactor(touch): remove unused average-accuracy calculation
giswqs Nov 15, 2026
23b1702
docs: reconcile release quality notes with current behavior
giswqs Nov 15, 2026
fc3686d
fix(plugins): report uninspected registry entries and partial lists
giswqs Nov 15, 2026
aa6edce
test(plugins): retain the malformed field-id fixture
giswqs Nov 15, 2026
a6e30be
fix(analysis): reject geocentric coordinates in public density API
giswqs Nov 15, 2026
85ec7ec
docs(geom): correct the coordinate tolerance decimal unit
giswqs Nov 15, 2026
2a5deb4
docs(privacy): describe photo metadata and credential field redaction
giswqs Nov 15, 2026
cf6d0eb
fix(plugins): satisfy the registry notice Clippy gate
giswqs Nov 15, 2026
5f02944
Merge remote-tracking branch 'origin/main' into fix/release-quality-s…
giswqs Nov 15, 2026
2ed752e
Address CodeRabbit review feedback
giswqs Nov 15, 2026
6e6c032
fix(import): preserve legend links and reconcile diagram notices
giswqs Nov 15, 2026
a4b467b
fix(project): retain normalized legend links after unbinding
giswqs Nov 15, 2026
83cd988
Deliver QGIS import details through session notices
giswqs Nov 15, 2026
6928327
Use the QGIS notice text module directly
giswqs Nov 15, 2026
9e0fae2
fix: report refused sign-ins and finish plugin cleanup
giswqs Nov 15, 2026
d0896e2
fix(mobile): bound event batches and preserve picker admission
giswqs Nov 15, 2026
497b181
fix(mobile): keep active document batches protected by process ownership
giswqs Nov 15, 2026
e0f4b36
Merge remote-tracking branch 'origin/main' into fix/release-quality-s…
giswqs Nov 15, 2026
6a7602b
Merge branch 'main' into fix/release-quality-sweep-2026-11-15
giswqs Nov 15, 2026
cc71c46
Merge remote-tracking branch 'origin/fix/release-quality-sweep-2026-1…
giswqs Nov 15, 2026
57752e2
fix(web): initialize the optional picker admission callback
giswqs Nov 15, 2026
a6eb8bf
Group QGIS import notices across layers with bounded samples
giswqs Nov 15, 2026
001980f
fix(ci): keep flaky test reports current and issue lookups exact
giswqs Nov 15, 2026
3bac756
Merge remote-tracking branch 'origin/main' into fix/release-quality-s…
giswqs Nov 15, 2026
8a74da2
Follow QGIS report order in notice sample regression
giswqs Nov 15, 2026
0cbab9d
docs: explain picker batch and encoded legend bounds
giswqs Nov 15, 2026
f6450a8
Merge remote-tracking branch 'origin/main' into fix/release-quality-s…
giswqs Nov 15, 2026
ed829b2
fix: relay complete diagnostics from detached whole reads
giswqs Nov 15, 2026
a18f003
test: construct unopened sources through their public fields
giswqs Nov 15, 2026
62c479e
fix(cli): report refused saved sign-ins before requests
giswqs Nov 15, 2026
2a3e4e4
fix: coalesce counted reader dimension loss on export
giswqs Nov 15, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .config/nextest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ retries = 2
fail-fast = false

[profile.ci.junit]
# target/nextest/ci/junit.xml: the report flaky-tests.sh reads (`<flakyFailure>` marks a test that
# passed only on a retry).
# target/nextest/ci/junit.xml: the report flaky-tests.sh reads (`<flakyFailure>` or `<flakyError>`
# marks a test that passed only on a retry).
path = "junit.xml"
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -255,13 +255,15 @@ jobs:
RUN: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
run: |
set -euo pipefail
[ -d flaky ] || exit 0
sort -u flaky/flaky-*.txt | while read -r test; do
shopt -s nullglob
files=(flaky/flaky-*.txt)
[ "${#files[@]}" -gt 0 ] || exit 0
sort -u "${files[@]}" | while read -r test; do
title="Flaky test: $test"
runners="$(grep -lxF -- "$test" flaky/flaky-*.txt | sed 's|^flaky/flaky-||; s|\.txt$||' | paste -sd, - | sed 's/,/, /g')"
body="$test failed and passed on a retry on $runners, for $GITHUB_SHA: $RUN"
open="$(gh issue list -R "$GITHUB_REPOSITORY" --state open --search "in:title \"$title\"" --json number,title \
| jq -r --arg t "$title" '[.[] | select(.title == $t)][0].number // ""')"
open="$(gh api --paginate "repos/$GITHUB_REPOSITORY/issues?state=open&per_page=100" \
| jq -sr --arg t "$title" '[.[][] | select(.pull_request | not) | select(.title == $t)][0].number // ""')"
if [ -n "$open" ]; then
gh issue comment "$open" -R "$GITHUB_REPOSITORY" --body "Flaky again: $body"
else
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ jobs:
run: |
set -euo pipefail
title="Nightly build failed"
open="$(gh issue list -R "$GITHUB_REPOSITORY" --state open --search "in:title \"$title\"" \
--json number,title --jq "[.[] | select(.title == \"$title\")][0].number // \"\"")"
open="$(gh api --paginate "repos/$GITHUB_REPOSITORY/issues?state=open&per_page=100" \
| jq -sr --arg t "$title" '[.[][] | select(.pull_request | not) | select(.title == $t)][0].number // ""')"
if [ "$RESULT" = incomplete ]; then
echo "The real-data tests didn't run (download failed): leaving the nightly issue as it is."
elif [ "$RESULT" = success ]; then
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ jobs:
- uses: taiki-e/install-action@cfdb7ed4ccc7c7dce37759eae89dc5674b469b39 # v2
with:
tool: cargo-nextest@0.9.151
- name: Clear the previous test report
shell: bash
run: rm -f target/nextest/ci/junit.xml
# PACKAGES is several words, so it is left unquoted. A pull request that changes only a
# package with no tests runs none (`--no-tests=warn`).
- name: Tests
Expand Down
8 changes: 5 additions & 3 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ is out of scope.
- A new background raster command or export, or a tool whose work grows with its input, goes in
the lists in `crates/engine/src/tests.rs` (`cancel_rasters`, `cancel_exports`, `cancel_tools`);
`cancel_rasters` and `cancel_exports` must match the background registries. A read-ahead command
(`reads::prepare`, such as `service.layers`) has no list: add its call to the test below by hand.
(`reads::prepare`, such as `service.layers`) has no list: add its call to
`long_commands_stop_when_cancelled_while_they_run` by hand.
`long_commands_stop_when_cancelled_while_they_run` fails one that never looks at Cancel;
`cancelling_at_each_check_leaves_nothing_behind` cancels each command of the three lists at its
first three checks and its last, and fails one that leaves the project, its undo steps or the
Expand Down Expand Up @@ -108,7 +109,7 @@ Work that splits into independent parts runs on several threads where practical:
A change that works where you tried it is often missing elsewhere. Before calling it done, say in
the pull request which of these it reaches and why the rest don't apply:
- the desktop app, the browser (file access through `Services`), the command line, Python, the
phone (the touch bar);
phone (the touch interface, `ui-touch`);
- the ribbon, shortcuts and command search; the Assistant and MCP (do their tool descriptions
show the new option?); plugins;
- the way back: what you add can be undone, removed or reopened.
Expand Down Expand Up @@ -137,7 +138,8 @@ packages ship (the release build fails on stale ones).
Pull requests run CI on Linux (plus the Android and iOS builds when they touch
`apps/rustgis-mobile`); pushes to `main` test every platform. When a pull request touches
platform-specific code, paths or file dialogs, label it `ci:windows` or `ci:macos` to test there,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGENTS.md (medium-low confidence, ~50%): the new CI-timing sentence is a new rule, not a check or test list. The "This file" section says a new rule goes under "Suggested AGENTS.md additions" in the pull request description, and a maintainer decides. Only a check or a test-list line should be edited here directly. The sentence "Label-triggered runs start the tests immediately; label-gated build jobs in ci.yml start from the next push." reads as a rule. Move it to the suggested additions, or say why it is a fact rather than a rule.

or `ci:full` for every platform and the release build.
or `ci:full` for every platform and the release build. Label-triggered runs start the tests
immediately; label-gated build jobs in `ci.yml` start from the next push.

## Review comments
- Fix in the pull request what a review finds wrong: bugs, crash paths, silent data loss, a broken
Expand Down
4 changes: 1 addition & 3 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,7 @@ attributes kept.
- A scene with a free camera and each layer's elevation mode (on the ground, relative, absolute),
Phase 2 of [#726](https://github.com/opengeos/RustGIS/issues/726), after the Z design above.
- LiDAR point layers (LAS/LAZ/COPC, read today as points) drawn at their heights in the scene.
- Terrain from several layers ([#1310](https://github.com/opengeos/RustGIS/issues/1310)), and
finer terrain once a tilted view settles
([#1523](https://github.com/opengeos/RustGIS/issues/1523)).
- Terrain from several layers ([#1310](https://github.com/opengeos/RustGIS/issues/1310)).
- 3D objects and 3D Tiles follow.

## Exploratory
Expand Down
48 changes: 34 additions & 14 deletions apps/rustgis-cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,16 @@ fn choose_provider(args: &[String], env: &Environment, saved: Option<&Saved>) ->
/// Builds a request's configuration without reading unrelated credentials during management.
/// A prompt may use the desktop's API key for its provider and address; model listing uses
/// only environment API keys, so `--models` never prompts for a saved API key.
fn configuration(provider: &str, args: &[String], env: &Environment, saved: Option<&Saved>) -> Config {
fn configuration(provider: &str, args: &[String], env: &Environment, saved: Option<&Saved>) -> Result<Config, String> {
let mut cfg = (env.config)(provider);
if cfg.login()
&& let Some(c) = rustgis_assistant::chatgpt::load_any()
{
cfg.sign_in(&c);
if cfg.login() {
let (credentials, warning) = rustgis_assistant::chatgpt::load_any_report();
if let Some(warning) = warning {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaviour change beyond the refused-store case (question, ~40% confidence). load_any_report returns a warning for any token-store failure, not only for a refused store. In that case it also returns a readable registration without its tokens. This return Err runs before the registration is used, so a keychain failure now fails ask (and ask --models with the ChatGPT provider) with an error. Before this change, the request went ahead signed out, with the sign-in hint. The error text is more accurate, but the PR description only mentions refused stores. Please confirm that token-store failures should fail the request. If they should not, return the error only when credentials is None.

return Err(format!("could not read saved ChatGPT sign-ins: {warning}"));
}
if let Some(c) = credentials {
cfg.sign_in(&c);
}
}
if let Some(m) = opt(args, "--model").map(str::to_string).or_else(|| env.model.clone()) {
cfg.model = m;
Expand All @@ -243,7 +247,7 @@ fn configuration(provider: &str, args: &[String], env: &Environment, saved: Opti
{
cfg.key = key.expose().to_string();
}
cfg
Ok(cfg)
}

const NEEDS_REQUEST: &str = "ask needs a request, e.g. rustgis-cli ask --sample \"Which countries have the largest GDP?\"";
Expand Down Expand Up @@ -374,7 +378,7 @@ fn ask(s: &mut Session, args: &[String], saved: Option<&Saved>, env: &Environmen
if !models && prompt.is_none() {
return Err(NEEDS_REQUEST.into());
}
let mut cfg = configuration(&provider, args, env, saved);
let mut cfg = configuration(&provider, args, env, saved)?;
// A signed-in account's requests renew its tokens as needed.
// Without a usable sign-in, say how to sign in before asking for anything.
if cfg.login()
Expand Down Expand Up @@ -1051,14 +1055,14 @@ mod tests {
fn a_prompt_uses_the_saved_key_but_model_listing_does_not_read_it() {
let store = anthropic_key();
let opted_in = saved(remembered(), &store);
let list = configuration("anthropic", &args(&["ask", "--models"]), &bare(), Some(&opted_in));
let list = configuration("anthropic", &args(&["ask", "--models"]), &bare(), Some(&opted_in)).unwrap();
let request = provider::models_request(&list);
assert!(request.headers.iter().all(|(_, value)| !value.contains("stored-sentinel")));
assert!(store.accounts().is_empty());
let environment_list = configuration("openai", &args(&["ask", "--models"]), &with_openai_key(), Some(&opted_in));
let environment_list = configuration("openai", &args(&["ask", "--models"]), &with_openai_key(), Some(&opted_in)).unwrap();
assert_eq!(environment_list.key, "env-key");
assert!(store.accounts().is_empty());
let prompt = configuration("anthropic", &args(&["ask", "--provider", "anthropic", "hi"]), &bare(), Some(&opted_in));
let prompt = configuration("anthropic", &args(&["ask", "--provider", "anthropic", "hi"]), &bare(), Some(&opted_in)).unwrap();
assert_eq!(prompt.key, "stored-sentinel");
assert_eq!(store.accounts(), ["assistant/anthropic"]);
}
Expand All @@ -1067,17 +1071,17 @@ mod tests {
fn without_the_opt_in_or_consent_no_key_is_read_and_the_environment_key_wins() {
let store = anthropic_key();
// No --use-saved-secrets: the model list goes out without the saved key.
let request = provider::models_request(&configuration("anthropic", &args(&["ask", "--models"]), &bare(), None));
let request = provider::models_request(&configuration("anthropic", &args(&["ask", "--models"]), &bare(), None).unwrap());
assert!(request.headers.iter().all(|(_, value)| !value.contains("stored-sentinel")));
// Opted in, but the desktop does not remember keys.
let off = saved(desktop(&[(provider::REMEMBER_KEY_PREF, "off")]), &store);
assert_eq!(configuration("anthropic", &args(&["ask", "hi"]), &bare(), Some(&off)).key, "");
assert_eq!(configuration("anthropic", &args(&["ask", "hi"]), &bare(), Some(&off)).unwrap().key, "");
// A key from the environment is the one used, and nothing is read.
let opted_in = saved(remembered(), &store);
assert_eq!(configuration("openai", &args(&["ask", "hi"]), &with_openai_key(), Some(&opted_in)).key, "env-key");
assert_eq!(configuration("openai", &args(&["ask", "hi"]), &with_openai_key(), Some(&opted_in)).unwrap().key, "env-key");
// The desktop sends its key to its own address only: another one gets no key.
let elsewhere = args(&["ask", "--base-url", "https://elsewhere.example/v1", "hi"]);
assert_eq!(configuration("anthropic", &elsewhere, &bare(), Some(&opted_in)).key, "");
assert_eq!(configuration("anthropic", &elsewhere, &bare(), Some(&opted_in)).unwrap().key, "");
assert!(store.accounts().is_empty());
}

Expand All @@ -1103,6 +1107,22 @@ mod tests {
false
}

/// A refused store is an actionable CLI error, while no store is a clean signed-out state.
#[test]
fn a_refused_chatgpt_store_is_reported_before_a_cli_request() {
if !in_isolated_settings("tests::a_refused_chatgpt_store_is_reported_before_a_cli_request") {
return;
}
let path = rustgis_assistant::chatgpt::auth_path().unwrap();
let text = "{\"version\":3,\"accounts\":[]}";
std::fs::write(&path, text).unwrap();
let error = configuration("chatgpt", &args(&["ask", "hi"]), &bare(), None).err().unwrap();
assert!(error.contains("could not read saved ChatGPT sign-ins") && error.contains("newer RustGIS"), "{error}");
assert_eq!(std::fs::read_to_string(&path).unwrap(), text);
std::fs::remove_file(&path).unwrap();
assert!(configuration("chatgpt", &args(&["ask", "hi"]), &bare(), None).unwrap().key.is_empty());
}

#[test]
fn managing_the_chatgpt_sign_in_never_reads_an_api_key() {
if !in_isolated_settings("tests::managing_the_chatgpt_sign_in_never_reads_an_api_key") {
Expand Down
4 changes: 4 additions & 0 deletions apps/rustgis-mobile/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ too_many_arguments = "allow"
type_complexity = "allow"

[dev-dependencies]
rustgis-ui-touch = { workspace = true }
eframe = { workspace = true, features = ["default_fonts", "wgpu", "x11", "wayland"] }
serde_json = { workspace = true }
log = { workspace = true }
rustgis-engine = { workspace = true }
rustgis-ui-egui = { workspace = true }

Expand Down
3 changes: 3 additions & 0 deletions apps/rustgis-mobile/build-apk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ strip=$(ls "$ANDROID_NDK_HOME"/toolchains/llvm/prebuilt/*/bin/llvm-strip | head
find "$out/apk/lib" -name librustgis_mobile.so -exec "$strip" {} \;
# Each segment aligned to 16 KB pages, which Android 15 phones may use and Google Play requires.
readelf=$(ls "$ANDROID_NDK_HOME"/toolchains/llvm/prebuilt/*/bin/llvm-readelf | head -1)
checked=0
while IFS= read -r -d '' so; do
checked=$((checked + 1))
# In an assignment of its own, so a readelf that fails stops the script.
info=$("$readelf" -lW "$so")
for align in $(awk '$1 == "LOAD" { print $NF }' <<< "$info"); do
Expand All @@ -106,6 +108,7 @@ while IFS= read -r -d '' so; do
fi
done
done < <(find "$out/apk/lib" -name '*.so' -print0)
[ "$checked" -gt 0 ] || { echo "build-apk: no native libraries to check for 16 KB alignment" >&2; exit 1; }

# The activity's Java half, compiled without Gradle: javac, then d8 to Android's bytecode.
rm -rf "$out/java" && mkdir -p "$out/java/classes" "$out/java/dex"
Expand Down
61 changes: 61 additions & 0 deletions apps/rustgis-mobile/java/org/rustgis/mobile/EventBuffer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
package org.rustgis.mobile;

/** Ordered phone events, with bounded position retention and bounded work per Rust frame. */
final class EventBuffer {
static final int PER_FRAME = 512;
private final java.util.ArrayDeque<String> events = new java.util.ArrayDeque<>();
private final int mostPositions;
private int positions;
private long dropped;

EventBuffer(int mostPositions) {
this.mostPositions = mostPositions;
}

void add(String event) {
boolean position = event.startsWith("position\t");
if (position && positions >= mostPositions) {
// Only position fixes may be discarded: picker completions and failures must reach
// Rust even when several days' positions filled the queue before them.
java.util.Iterator<String> pending = events.iterator();
while (pending.hasNext()) {
if (pending.next().startsWith("position\t")) {
pending.remove();
positions--;
dropped++;
break;
}
}
}
events.add(event.replace('\n', ' ').replace('\r', ' '));
if (position) {
positions++;
}
}

String take() {
StringBuilder taken = new StringBuilder();
int count = 0;
if (dropped > 0) {
taken.append("failed\t").append(dropped)
.append(" positions found while RustGIS was out of sight were dropped: more were waiting than it keeps.");
dropped = 0;
count++;
}
while (count < PER_FRAME && !events.isEmpty()) {
String event = events.removeFirst();
if (event.startsWith("position\t")) {
positions--;
}
if (count++ > 0) {
taken.append('\n');
}
taken.append(event);
}
return taken.toString();
}

boolean isEmpty() {
return events.isEmpty() && dropped == 0;
}
}
23 changes: 23 additions & 0 deletions apps/rustgis-mobile/java/org/rustgis/mobile/LocationProviders.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package org.rustgis.mobile;

/** Providers successfully registered for the current listener, confined to Android's main thread. */
final class LocationProviders {
private final java.util.HashSet<String> requested = new java.util.HashSet<>();

void add(String provider) {
requested.add(provider);
}

void clear() {
requested.clear();
}

boolean anyEnabled(java.util.function.Predicate<String> enabled) {
for (String provider : requested) {
if (enabled.test(provider)) {
return true;
}
}
return false;
}
}
Loading
Loading