Repository navigation
test: verify counted loss notices for every export #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely failing for
stream == true. The streamed GeoJSON and CSV paths never see the counted reader note, so this exact-match assertion should fail on the first export.Why:
share.exportLayertakes the chunk branch for streamed.geojson(export::streamsincludesgeojsonandcsv;share.rs:723). That branch callschunk_export()andwrite_source_to, neither of which carriesinfo.notes.unreadablestaysUnreadable::default(), sozm_notedis false andcoalesce_read_zmkeeps only the genericzm_export_note. The result is"<path>: its geometry has no Z or M values, which were dropped when wells was read", not thewells: 1 feature had Z or M values…text this test expects.data.convertto.csvhas the same shape: its chunk branch (workflows.rs:1903-1928) builds notes fromexport_notesand never readsinfo.notes.The counted note only reaches the export on the
load_all_countedpath (share.rs:724-725,workflows.rs:1930-1943), which streamed GeoJSON and CSV skip.The PR body also says the focused test result is still pending, so this probably hasn't been run. Please run
cargo test -p rustgis-engine dropped_z_values_are_said_on_import_and_exportbefore merging.Either the chunk branches need to carry the reader's counted Z/M note (and set
zm_noted), or the streamed expectation needs to be the generic wording. The comment at lines 23011-23012 ("A counted reader diagnostic replaces the generic export warning") describes behaviour the chunk path doesn't have.