Repository navigation
Conversation
#2196 made an export of a layer read in place keep the counted note its fresh read gives ("1 feature had Z or M values ... dropped") in place of the generic "its geometry has no Z or M values" warning (coalesce_read_zm). dropped_z_values_are_said_on_import_and_export still looked only for the generic text, so it has failed on main since. Accept the counted note for the streamed case; a layer read whole must still give the export's own warning, and a 2D layer nothing.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Code reviewI found no bugs, security issues, performance problems, or AGENTS.md violations in this PR. I posted no inline comments. Bugs: none.
Security: none. Test-only change. Performance: none. Quality: nothing worth raising. The predicate is a loose disjunction, and it could be tightened to match the layer name, but the counted note text doesn't carry the name, so that would need a different helper. That is a release-quality-pass item at most, and I did not post it. AGENTS.md:
Prior reviews: none on this PR, so there were no earlier concerns to leave alone. Change sizeCompared: the whole PR against main (merge base 67a99f2 to PR head a09bd7e).
|
📖 Docs preview
GitHub Pages takes a minute or two to publish a new commit. |
|
Superseded by #2231, which fixed the same test on main (and checks the exact notice text). |
tests::dropped_z_values_are_said_on_import_and_exportfails onmain(all three nextest tries), which blocks the v0.7.0 release PR #2232. Runs onmainkept being cancelled by newer pushes, so it went unnoticed.Cause: #2196 made an export of a layer read in place keep the counted note its fresh read gives (
out.geojson: wells: 1 feature had Z or M values (heights or measures), which were dropped: …) instead of also giving the genericits geometry has no Z or M valueswarning (coalesce_read_zmincrates/engine/src/cmd/share.rs). The loss is still reported, in the reader's words. The test still looked only for the generic text in thestream: truecase.Fix: for the streamed case the test accepts the counted
zm_note(Some(1))as well. A layer read whole must still give the export's own warning, and a 2D layer's export must still say nothing about Z or M. Test-only change; the product behaviour is what #2196 intended.Reaches: tests only.
Summary by CodeRabbit