Repository navigation
feat(layout): a background on every layout element but the map frame (#2257) #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jgregoriorincon
merged 5 commits into
opengeos:main
from
jgregoriorincon:feat/2257-layout-element-background
Nov 16, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bb37509
feat(layout): a background on every layout element but the map frame …
jgregoriorincon cac2d79
fix(layout): projects with an element background require layout-eleme…
jgregoriorincon 804b9aa
style(schema): end the element background fixture with a newline (#2257)
jgregoriorincon f041f6b
fix(layout): say a map frame's background was removed, and clamp the …
jgregoriorincon b81a3a5
fix(layout): saved commands that set an element background require la…
jgregoriorincon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug (confidence ~55%):
layout.importwith inline text is not covered by this predicate.layout.importtakes{"text": …}(the same layout JSON as a.rgislayoutfile, seecmd/layout.rsimport). A saved task step, script line, notebook cell or history entry that imports a layout with a background inline therefore saves withoutlayout-element-background, and an older reader would replay it and silently drop the background. That is the loss the capability exists to prevent, and it is a saved command, not a layout file, so the.rgislayoutgap the docs accept does not cover it. A{"path": …}import can't be seen at save time and stays with that accepted gap.A conservative fix is to treat any inline text that mentions a background as requiring the capability (over-requiring is safe; the cost is one refused older read):
Please add a test next to
element_background_capability_follows_saved_layoutswith a savedlayout.importstep whosetextcarries a background (requires) and one whose text has none (doesn't).