Repository navigation
test(analysis): pin Repair Geometry where rules for inside differ, and cancel Check and Repair Geometry (#2003) #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deniial00
merged 4 commits into
opengeos:main
from
flight1973:test/repair-geometry-pins
Nov 17, 2026
+179
−4
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1798fb4
test(analysis): pin Repair Geometry where rules for inside differ, an…
flight1973 8b2c9ce
Merge remote-tracking branch 'origin/main' into test/repair-geometry-…
flight1973 1e6213c
test(analysis): run each pinned shape with one ring at a time reverse…
flight1973 d000232
Merge branch 'main' into test/repair-geometry-pins
giswqs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says Check Geometry and Repair Geometry were added to
cancel_toolsand that both cancel tests run them, but that list isn't in this PR.cancel_toolsdoesn't exist anywhere in the repo,crates/engine/src/tests/cancellation.rsis not in the changed files, and this PR only changes this doc comment. The tool list incancellation.rs(around line 222) has nocheckGeometryorrepairGeometryentry.Both tools grow with their input and look at Cancel per feature (
repair_geometry.rs:104,179,check_geometry.rs:85,139), so AGENTS.md's "a tool whose work grows with its input goes in the lists inlong_commands" applies. Adding them to thattoolsarray would be the missing change, along the lines of:I haven't run the cancel tests, so I can't say whether these fixtures pass them. Either way the PR description's "cancel tests pass with the two tools added" is not true for this head commit.