Skip to content

Update Isoliner to 0.1.3 - #75

Open
Valery35 wants to merge 1 commit into
opengeos:mainfrom
Valery35:patch-4
Open

Valery35 wants to merge 1 commit into
opengeos:mainfrom
Valery35:patch-4

Conversation

@Valery35

@Valery35 Valery35 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Plugin: Isoliner (isoliner), Valery35/isoliner-rustgis

What it does: updates registry/isoliner.json from 0.1.2 to 0.1.3. The 0.1.3 release adds the first raster command (2.05 Slope and aspect) and raises the lower RustGIS bound to 0.7.0. Nothing else changes.

How I tested it: the package is the 0.1.3 GitHub release asset; its SHA-256 matches the release digest.

  • The entry's source.url is a release asset of the plugin's repository, and sha256 is that file's.
  • The plugin asks only for the permissions it uses.

Summary by CodeRabbit

  • Updates
    • Updated the isoliner plugin registry entry to reference release 0.1.3.

@Valery35
Valery35 requested a review from giswqs as a code owner November 18, 2026 16:47
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Isoliner registry entry now points to the rustgis-v0.1.3 plugin release and uses its SHA-256 checksum.

Changes: Isoliner release update

Layer / File(s) Summary
Update Isoliner registry release
registry/isoliner.json
The registry entry now uses the rustgis-v0.1.3 download URL and checksum.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to eb27d

This updates the Isoliner registry entry to release 0.1.3 with its matching checksum. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Update Isoliner to 0.1.3" matches the single change in the PR, which updates registry/isoliner.json from the 0.1.2 release to the 0.1.3 release. It names the plugin and the version, so a te…
Description check Passed The description covers the plugin name and repository link, a summary of what the update does, the testing claim (the 0.1.3 release asset and its matching SHA-256 digest), and both checklist items fro…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Update Isoliner to 0.1.3" matches the single change in the PR, which updates registry/isoliner.json from the 0.1.2 release to the 0.1.3 release. It names the plugin and the version, so a teammate scanning history can identify the change.

Full details: Description check

Explanation

The description covers the plugin name and repository link, a summary of what the update does, the testing claim (the 0.1.3 release asset and its matching SHA-256 digest), and both checklist items from the template. The template asks for the RustGIS version and platform in the testing section. The description gives only the package and digest, not the RustGIS version or the desktop, web, or CLI surface used for testing. This is a minor gap, so the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the release trail
The new URL is set in place
A fresh checksum joins the file
The old version hops away
Isoliner finds its next release

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ddcffbe6-ae94-4328-b075-7742426bb11c
Commits

Reviewing files that changed from the base of the PR and between 3e3d936 and eb27d72.

Files selected for processing: 1

  • registry/isoliner.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread registry/isoliner.json
"url": "https://github.com/Valery35/isoliner-rustgis/releases/download/rustgis-v0.1.2/isoliner-0.1.2.rgplugin",
"sha256": "b45a250834551ba8f330e44c39a3b068b682ae80f341e311648dfc6e9ce7c652"
"url": "https://github.com/Valery35/isoliner-rustgis/releases/download/rustgis-v0.1.3/isoliner-0.1.3.rgplugin",
"sha256": "3a3fe019550b06be55e831512f85d1f49425bd611a909b23e53093595234df01"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 0.1.3 package is a process plugin that ships a prebuilt Windows executable (bin/isoliner-rustgis.exe, 2.4 MB). It isn't sandboxed and has files and edit permissions. The reviewer can't read the binary here. Before merging, a maintainer needs to confirm that the source and a reproducible build for this exact release are linked (for example a tagged commit and CI workflow in Valery35/isoliner-rustgis that produce this asset). The new slope/aspect command also reads a DEM and writes two GeoTIFFs, so check which output paths it uses. Confidence: medium.

@github-actions

Copy link
Copy Markdown

Code review

Bugs

  • None found in the diff. It changes only the source.url and sha256 in registry/isoliner.json, and the id is unchanged. (high)

Security

  • Prebuilt binary: the package is a non-sandboxed process plugin whose only code is bin/isoliner-rustgis.exe (2,467,840 B, not unpacked, too large to review here). It has files and edit permissions. I could not review it. Source and build for this release must be confirmed by a maintainer before merge. The PR description claims the source is at the linked repository, but I could not verify that, and I could not check that the repository builds this binary. (medium)
  • The new slope-aspect command takes a raster layer name and adds two GeoTIFFs. Where it writes them is not visible in the manifest. (low)
  • The package is Windows-only (run has only a windows key). The description has no platform note. (low)

Performance

  • None found.

Quality

  • The manifest is consistent: id isoliner, version 0.1.3, minRustgisVersion 0.7.0, matching the PR description. The slope-aspect command's form and parameter kind (rasterLayer) look sensible. (medium)

CLAUDE.md

  • No CLAUDE.md issues applicable.

Plugin packages

id version runtime package module permissions module imports / runs commands named in strings
isoliner 0.1.3 process (not sandboxed) 931,318 B 2 files files, edit runs {"windows": ["bin/isoliner-rustgis.exe", "rustgis-plugin"]} n/a: read its code

Assessment: only plugin.json could be read. The program is a single Windows executable that was not unpacked, so no code review was possible. Needs maintainer resolution on source and reproducible build, as described above. The package's SHA-256 was verified by the trusted step. I did not check the hash against the release digest myself.

Change size

Compared: the whole PR against main (merge base 3e3d936 to PR head eb27d72).

Metric Value
Files changed 1 (0 added, 1 modified, 0 removed, 0 renamed)
Size before 306 B
Size after 306 B
Total size change +0 B
File Before After Change
registry/isoliner.json 306 B 306 B +0 B

@github-actions

Copy link
Copy Markdown

🧩 Plugin preview

Open in RustGIS: web.rustgis.app's Plugin Manager on this pull request's registry (1 plugin package from this pull request). Install from Browse; RustGIS shows the permissions first.

Item Value
Preview https://pr-75.rustgis-plugins-preview.pages.dev
Registry (desktop: Plugin Manager › Settings) https://pr-75.rustgis-plugins-preview.pages.dev/registry.json
This commit https://0aba7da3.rustgis-plugins-preview.pages.dev
Commit eb27d72

Unreviewed code: install it only to review this pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant